From: Marcel Holtmann <marcel@holtmann.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency
Date: Sat, 17 Oct 2015 11:15:17 +0200 [thread overview]
Message-ID: <A0A720F0-8950-4B1D-99A9-6A0059E8BF8B@holtmann.org> (raw)
In-Reply-To: <4199320.WWtqtXexhZ@wuerfel>
Hi Arnd,
> The change to bpa10x to use the h4_recv_buf helper added a dependency
> on BT_HCIUART. This was incorrectly added to Kconfig by adding a
> 'select' statement, which now in turn causes build failures
> when CONFIG_TTY is not set:
>
> warning: (BT_HCIBPA10X) selects BT_HCIUART which has unmet direct dependencies (NET && BT && TTY)
> vers/built-in.o: In function `hci_uart_tty_receive':
> fpga-mgr.c:(.text+0x282824): undefined reference to `tty_unthrottle'
> drivers/built-in.o: In function `hci_uart_tty_ioctl':
> fpga-mgr.c:(.text+0x282aa0): undefined reference to `n_tty_ioctl_helper'
> drivers/built-in.o: In function `hci_uart_flush':
>
> This replaces the 'select BT_HCIUART' dependency with 'depends on', which
> does not have this kind of problem. Alternatively, one could add 'depends
> on TTY', but avoiding 'select' on user-visible options is generally the
> preferred choice as that does not introduce the potential for dependency
> loops or incomplete dependency chains.
the intention here was to use select, but that seems to open all sorts of problems. Since I am most likely the only person that still has this device and attaches it to Linux, I am fine in going the easier path with depends on.
Patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2015-10-17 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 22:03 Arnd Bergmann
2015-10-17 9:15 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A0A720F0-8950-4B1D-99A9-6A0059E8BF8B@holtmann.org \
--to=marcel@holtmann.org \
--cc=arnd@arndb.de \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®