From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933176AbdERMAT convert rfc822-to-8bit (ORCPT ); Thu, 18 May 2017 08:00:19 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:32983 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745AbdERMAO (ORCPT ); Thu, 18 May 2017 08:00:14 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 From: Marcel Holtmann In-Reply-To: <20170508093911.25228-1-tobias.regnery@gmail.com> Date: Thu, 18 May 2017 14:00:12 +0200 Cc: "Gustavo F. Padovan" , Johan Hedberg , "open list:BLUETOOTH DRIVERS" , linux-kernel@vger.kernel.org, sre@kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20170508093911.25228-1-tobias.regnery@gmail.com> To: Tobias Regnery X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tobias, > We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and > CONFIG_BT_HCIUART_H4=n: > > drivers/bluetooth/hci_nokia.c: In function 'nokia_recv': > drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration] > ... > > Fix this by selecting the BT_HCIUART_H4 symbol like all the other users > of the protocoll. > > Fixes: 7bb318680e86 ("Bluetooth: add nokia driver") > Signed-off-by: Tobias Regnery > --- > drivers/bluetooth/Kconfig | 1 + > 1 file changed, 1 insertion(+) patch has been applied to bluetooth-next tree. Regards Marcel