From: "Sardañons, Eliel" <Eliel.Sardanons@philips.edu.ar>
To: linux-kernel@vger.kernel.org
Subject: kernel/sched.c questions
Date: Wed, 4 Apr 2001 16:52:32 -0300 [thread overview]
Message-ID: <A0C675E9DC2CD411A5870040053AEBA028416D@MAINSERVER> (raw)
Hello, I would like to know why you put this two functions:
void scheduling_functions_start_here(void) { }
...
void scheduling_functions_end_here(void) { }
why you put 'case TASK_RUNNING'
switch (prev->state) {
case TASK_INTERRUPTIBLE:
if (signal_pending(prev)) {
prev->state = TASK_RUNNING;
break;
}
default:
del_from_runqueue(prev);
case TASK_RUNNING:
}
and the last one:
in the function schedule() you always use this syntax:
-----
if (a_condition)
goto bebe;
bebe_back
bebe:
do_bebe();
goto bebe_back;
------
why not just doing:
if (a_condition)
do_bebe();
I know that goto's are better but finaly you are jumping to a function and
then calling the function. I think you can improve performance doing this.
next reply other threads:[~2001-04-04 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-04 19:52 Sardañons, Eliel [this message]
2001-04-04 20:08 ` Tim Walberg
2001-04-04 20:20 ` Andi Kleen
2001-04-04 20:21 ` Bjorn Wesen
2001-04-04 21:22 ` Richard B. Johnson
2001-04-04 20:29 ` Stuart MacDonald
2001-04-05 20:28 ` Steven Walter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A0C675E9DC2CD411A5870040053AEBA028416D@MAINSERVER \
--to=eliel.sardanons@philips.edu.ar \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®