From: "IpsLinux" <ipslinux@adaptec.com>
To: "Adrian Bunk" <bunk@fs.tum.de>,
"Marcelo Tosatti" <marcelo.tosatti@cyclades.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [patch] 2.4.27-pre3: SCSI ips compile error
Date: Thu, 20 May 2004 09:50:42 -0400 [thread overview]
Message-ID: <A121ABA5B472B74EB59076B8E3C8F0192AA469@rtpe2k01.adaptec.com> (raw)
Adaptec had already discovered this error also and were in the process
of testing an update.
I concur with this change.
Jack
-----Original Message-----
From: Adrian Bunk [mailto:bunk@fs.tum.de]
Sent: Thursday, May 20, 2004 9:46 AM
To: Marcelo Tosatti; IpsLinux
Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org
Subject: [patch] 2.4.27-pre3: SCSI ips compile error
On Tue, May 18, 2004 at 05:30:40PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.27-pre2 to v2.4.27-pre3
>============================================
>...
> Jack Hammer:
> o ServeRAID driver update to 7.00.15: sync with v2.6 ...
It was nice if people would actually test at least the compilation of
their changes instead of blindly submitting the latest version of a
driver...
<-- snip -->
...
gcc -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.27-pre3-full/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
-nostdinc -iwithprefix include -DKBUILD_BASENAME=ips -c -o ips.o ips.c
In file included from ips.c:180:
ips.h:99: error: redefinition of `irqreturn_t'
/home/bunk/linux/kernel-2.4/linux-2.4.27-pre3-full/include/linux/interru
pt.h:16:
error: `irqreturn_t' previously declared here
make[3]: *** [ips.o] Error 1
make[3]: Leaving directory
`/home/bunk/linux/kernel-2.4/linux-2.4.27-pre3-full/drivers/scsi'
<-- snip -->
irqreturn_t was added to interrupt.h in 2.4.23, released nearly
6 months (!) ago.
Trivial fix below.
cu
Adrian
--- linux-2.4.27-pre3-full/drivers/scsi/ips.h.old 2004-05-19
21:40:58.000000000 +0200
+++ linux-2.4.27-pre3-full/drivers/scsi/ips.h 2004-05-19
21:42:01.000000000 +0200
@@ -95,11 +95,14 @@
#define scsi_set_pci_device(sh,dev) (0)
#endif
- #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
+ #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,23)
typedef void irqreturn_t;
#define IRQ_NONE
#define IRQ_HANDLED
#define IRQ_RETVAL(x)
+ #endif
+
+ #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
#define IPS_REGISTER_HOSTS(SHT)
scsi_register_module(MODULE_SCSI_HA,SHT)
#define IPS_UNREGISTER_HOSTS(SHT)
scsi_unregister_module(MODULE_SCSI_HA,SHT)
#define IPS_ADD_HOST(shost,device)
next reply other threads:[~2004-05-22 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-20 13:50 IpsLinux [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-05-18 20:30 Linux 2.4.27-pre3 Marcelo Tosatti
2004-05-20 13:46 ` [patch] 2.4.27-pre3: SCSI ips compile error Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A121ABA5B472B74EB59076B8E3C8F0192AA469@rtpe2k01.adaptec.com \
--to=ipslinux@adaptec.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®