From: "Hammer, Jack" <Jack_Hammer@adaptec.com>
To: <arjanv@redhat.com>
Cc: "Adrian Bunk" <bunk@fs.tum.de>,
"Marcelo Tosatti" <marcelo.tosatti@cyclades.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: RE: 2.4.28-pre3: broken ips update
Date: Mon, 13 Sep 2004 11:00:43 -0400 [thread overview]
Message-ID: <A121ABA5B472B74EB59076B8E3C8F01979658B@rtpe2k01.adaptec.com> (raw)
I concur with Arjan's critique.
Please disregard this patch and I will create a new one, with Arjan's
recommendation, shortly.
Jack
-----Original Message-----
From: Arjan van de Ven [mailto:arjanv@redhat.com]
Sent: Monday, September 13, 2004 10:46 AM
To: Hammer, Jack
Cc: Adrian Bunk; Marcelo Tosatti; linux-kernel@vger.kernel.org;
linux-scsi@vger.kernel.org
Subject: RE: 2.4.28-pre3: broken ips update
On Mon, 2004-09-13 at 16:28, Hammer, Jack wrote:
> Marcelo,
> --- linux.orig/drivers/scsi/ips.h Mon Sep 13 09:40:04 2004
> +++ linux/drivers/scsi/ips.h Mon Sep 13 09:40:27 2004
> @@ -97,7 +97,7 @@
>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
>
> - #ifndef irqreturn_t
> + #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,23)
> typedef void irqreturn_t;
> #endif
>
your fix is wrong.
you should nuke all version codes, and ONLY ifndef for IRQ_NONE and
nothing else. That's not just cosmetics, that's also to make keep
working with those exact vendor kernels you claim to have tested on :)
next reply other threads:[~2004-09-13 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 15:00 Hammer, Jack [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 18:01 Hammer, Jack
2004-09-13 14:28 Hammer, Jack
2004-09-13 14:42 ` Matthew Wilcox
2004-09-13 14:46 ` Arjan van de Ven
2004-09-11 22:01 Linux 2.4.28-pre3 Marcelo Tosatti
2004-09-13 7:03 ` 2.4.28-pre3: broken ips update Adrian Bunk
2004-09-13 14:24 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A121ABA5B472B74EB59076B8E3C8F01979658B@rtpe2k01.adaptec.com \
--to=jack_hammer@adaptec.com \
--cc=arjanv@redhat.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®