From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA765C433EF for ; Fri, 22 Apr 2022 11:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447133AbiDVLrO (ORCPT ); Fri, 22 Apr 2022 07:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1447119AbiDVLrE (ORCPT ); Fri, 22 Apr 2022 07:47:04 -0400 Received: from hutie.ust.cz (hutie.ust.cz [185.8.165.127]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 224E5546B5; Fri, 22 Apr 2022 04:44:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1650627847; bh=FpuPF57lqV2wF0ozxJVgJREDohc1ui5JNgdpVwE+l8w=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=dbRI4qKchxCMWHz/gRQ8gR1uvvn7q5BnJWLyllNZscu8zPDEr7VSPjV96/jjfK8Do 8A5M9XStn6yvgo/Fy0WO7RvQsnYEZt0e7qpaI+kedi46sXd3oIbt4NUPGClhTAI4qc /vctMet+PKq2Cn8h8xKfhCfdMfXGEddPIrsxnkGo= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver From: =?utf-8?Q?Martin_Povi=C5=A1er?= In-Reply-To: Date: Fri, 22 Apr 2022 13:44:06 +0200 Cc: =?utf-8?Q?Martin_Povi=C5=A1er?= , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis , Hector Martin , Sven Peter Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220331000449.41062-1-povik+lin@cutebit.org> <6D199EAB-FE14-4030-96A7-2E0E89D25FAB@cutebit.org> To: Mark Brown Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 22. 4. 2022, at 13:33, Mark Brown wrote: >=20 > On Fri, Apr 22, 2022 at 01:28:20PM +0200, Martin Povi=C5=A1er wrote: >>> On 22. 4. 2022, at 13:19, Mark Brown wrote: >>> On Fri, Apr 22, 2022 at 12:43:30PM +0200, Martin Povi=C5=A1er wrote: >=20 >>>> One final thought on the playback routing controls: On systems with = >2 >>>> speakers, the codecs need to be assigned slots through = set_tdm_slot. >>>> The macaudio driver RFCed here assigns a single slot to each = speaker, >>>> making the effect of each speaker's routing control this: >=20 > ... >=20 >>> I don't quite grasp the difference between the arrangement you're >>> proposing and assigning a single slot to each speaker? Possibly = it's >>> just a reordering of the slots? >=20 >> Ah, maybe what=E2=80=99s missing is the fact that the way the speaker = amp drivers >> are written, if they are assigned two slots with a call to = set_tdm_slot, >> the first slot is considered 'left' and the second is 'right'. >=20 >> So in the arrangement I am proposing the 'Left', 'Right' and = 'LeftRight' >> values of the routing control have the nominal effect (within the = left-right >> speaker pair), while in the other arrangement it is as I described = above. >=20 > So previously each speaker would get two slots but now it just gets = one? No the other way around. Previously (with the driver as it is RFCed), each speaker gets a single slot, and 'Left', 'Right' and =E2=80=98LeftRigh= t' values of the routing control don't do anything different from each other (well except maybe 'LeftRight' lessens the volume due to how the chip handles the edge case of mixing down two channels from the same slot). With the new arrangement I am proposing, the two speakers in a = left-right pair get both the same two slots, meaning they get to choose one of the two slots based on the 'Left' 'Right' value of their routing control.