mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Håkon Bugge" <haakon.bugge@oracle.com>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	"David S . Miller" <davem@davemloft.net>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [v2,0/2] net: if_arp: use define instead of hard-coded value
Date: Tue, 23 Oct 2018 14:30:57 +0200	[thread overview]
Message-ID: <A1A93434-9496-4029-9A53-2D64D56CB846@oracle.com> (raw)
In-Reply-To: <20181009142724.2213012-1-Haakon.Bugge@oracle.com>



> On 9 Oct 2018, at 16:27, Håkon Bugge <haakon.bugge@oracle.com> wrote:
> 
> Struct arpreq contains the name of the device. All other places in the
> kernel, the define IFNAMSIZ is used to designate its size. But in
> if_arp.h, a literal constant is used.
> 
> Fixed by explicitly including uapi/linu/if.h, where IFNAMSIZ is defined.
> 
> The series also fixes some incorrect indents.
> 
> 
> v1 -> v2:
>   * Include uapi/linux/if.h from if_arp.h
>   * Added Stephen's t-b
> 
> Håkon Bugge (2):
>  net: if_arp: Fix incorrect indents
>  net: if_arp: use define instead of hard-coded value
> 
> include/uapi/linux/if_arp.h | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
> ---
> 2.14.3

Just a friendly reminder.


Thxs, Håkon


> 
> 
> From a36b99413ea5beca1539f4faf065f33c7c19e6a5 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?H=C3=A5kon=20Bugge?= <Haakon.Bugge@oracle.com>
> Date: Fri, 21 Sep 2018 11:28:36 +0200
> Subject: [PATCH 0/2]
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Struct arpreq contains the name of the device. All other places in the
> kernel, the define IFNAMSIZ is used to designate its size. But in
> if_arp.h, a literal constant is used.
> 
> As it could be good reasons to use constants instead of the defines in
> include files under uapi, it seems to be OK to use the define here,
> without opening a can of worms in user-land.
> 
> This because if_arp.h includes netdevice.h, which also uses
> IFNAMSIZ. For the distros I have checked, this also holds true for the
> use-land side.
> 
> The series also fixes some incorrect indents.
> 
> Håkon Bugge (2):
>  net: if_arp: Fix incorrect indents
>  net: if_arp: use define instead of hard-coded value
> 
> include/uapi/linux/if_arp.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
> 
> --
> 2.14.3


  parent reply	other threads:[~2018-10-23 12:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 14:27 [PATCH v2 0/2] " Håkon Bugge
2018-10-09 14:27 ` [PATCH v2 1/2] net: if_arp: Fix incorrect indents Håkon Bugge
2018-10-09 14:27 ` [PATCH v2 2/2] net: if_arp: use define instead of hard-coded value Håkon Bugge
2018-10-23 12:30 ` Håkon Bugge [this message]
2018-10-23 16:11   ` [v2,0/2] " David Miller
2018-10-23 16:31     ` Håkon Bugge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A1A93434-9496-4029-9A53-2D64D56CB846@oracle.com \
    --to=haakon.bugge@oracle.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=stephen@networkplumber.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®