From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FE152D592F for ; Wed, 25 Feb 2026 18:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043062; cv=none; b=EV3d+WzJNuY5xzHceVecPQCr4HKNWs++9hVWEl5NCGZF6jQCYSWmTh9LPGSB1TG4Yml5YaZvAFzahsAW4pEzZQ6nu6kiWEuQZe7Vy0jHStztKd5BmqvzIqU6rAh+eauda6mE+FD1a8pFXTaIU5LOatrPq1RLoHBHbTjUqn9Xxuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043062; c=relaxed/simple; bh=/DTq+mu38B5JTYVS2ovUXmlIZA26WuU6CrQ7mayOxpI=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=cn98VY8yLL5oJa9LkoUuWYu5Msqxab53UpKmmBlYIRFm4yTtfi6WOUgyFFcsjMPyJ1oIDk5AVOYojcKRMpure4O4bz6+BwzWK3Xkw7w6IwYc2dX9zogA8UP2oW+9YclatMxIoEPhSm4kB2ZC35ZWu4s5aavrHyjpwH3T/r/kWJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CwXVjloL; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CwXVjloL" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-12713e56abdso883060c88.1 for ; Wed, 25 Feb 2026 10:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772043060; x=1772647860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=Bi4+5LDlWqkxz4K+29Fb02seelPMRm+o5ZL1AxypHh8=; b=CwXVjloLDWwRo07rhy5VqgP4xkC9aQP+Un1/ILlUcm0eAxOVKGFP4DSwD9jVE5vHmW shrrEyviSkSisfmV825xaAXMk4eQR1MS5/pAvcgYe+eoC/zOWxPV7M++6B4ZaEpQVlrs +YzzSAy7T8pQ20FaCLlyXqTwDCekb2rxWADQ6r7Uum1Nx6owF1HgPA+xrZMwoyybdGE0 hmEHRvVI8wjehWo2RJUYhgmFyhpIM51tU+UtlFRwG1XHligm5Y43uOHKk/O3dMJ4iGth yxNLM4Rrxwc570Bd7TBJD5E98iqXef1rVyZooTwQzY2ClwAEeWzzQLFFYfPYrIHygqZg +lig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772043060; x=1772647860; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bi4+5LDlWqkxz4K+29Fb02seelPMRm+o5ZL1AxypHh8=; b=UxAB/13XSzmzfHmnFyklcyuR/EhFYm/lUH0KtlfQdN4KqoDT5DdNyTj/ix0ZZf06mi aetpvSSOJHFCTlbVaYsFZw1vcqmGSPGYfuGSKcj9BQQKarSErAKKBpq/gHXsL453KsYw nzjClfteUpegmXW9vAnpsLIq+uhAVzN4sBumPSAIe8fNezm5S8P11ezOOncPwU0z3k79 vW13vVVHgupztpSKBOFKyNCHvii3C+qdYNRyM/2kmEhcI2vuP2Nxg+7f84HX7NXizvjc 7MNB+5/wVS+kcCyFZluFcaIwaYCMswkQjK+FbSXCxcHYJNpXMbkE3Ec/GHsPupryR8VK Fbrg== X-Forwarded-Encrypted: i=1; AJvYcCWYMwxUwcP6hy39i4qx1tF6qCoK3f0qoAQIbIyNWFaKUh+sbButsVr3AXApdfEFu5Yjvf5zqybD/4gnSfs=@vger.kernel.org X-Gm-Message-State: AOJu0YxpJOtiVj+TU3l7kSMEY/DYWBJAw3hv6w+e71/c7Qf7H9Ysc5AC 7c8hip9+lxv0ZHbGq6aflQraAH3ho/Qeeh0tJfc3Nsf2hh1J+lUtF9EW X-Gm-Gg: ATEYQzz9kfBGEFB06zmFWDv/u4XgqyH8qeWgnomoUPWETqwbmzTnX2hISIUu2Za7pou lUnxae0LZjA2K51Xo+tAPJt0cPKGbtQugS2TNnIHbkCtjvfNnyCQng4R/ofFgmHthuNfwzgIfYq OO4+xJ+9/MLzXK6d2xbdIeBIvBmWF39eCLlvQa+3u8PsdEtS/fh58QB4+uKUO0zJycH9vOzwLsi eMnLy8nJbUOoAvMNlx3p8zOuYSV0AqDEASwHk0pJiD/invLqzhx5b3g+VuEu215lLoysAgLKSCU Q/R0Bpf/f6pIAqyEMHk4hRnD5RHQ55x7zAsboG6YWf/VCJgyAVlXt5SRLbmpoSUAGUgqGlv1S0v vyVDtCqGPD72YPO6m3I9IhNIRbqYvCjzTj8EvzZ+F/W8KVcoU44U3u7diTHxRdYZriCuzsS4UdG 0fO6OFaqCT7Y/ACJJClklxzymgEL7dcMmhT9K/b4+q36Wz0YbPgceZl4DR6mL8gAry6Rv1Ct7sT sgFJb58P2PgIcY2F/ClUg== X-Received: by 2002:a05:7022:2391:b0:11b:2a5:3b9b with SMTP id a92af1059eb24-1277f508a82mr1750185c88.8.1772043060275; Wed, 25 Feb 2026 10:11:00 -0800 (PST) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7da4775dsm9436119eec.2.2026.02.25.10.10.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 10:10:59 -0800 (PST) Date: Wed, 25 Feb 2026 10:11:01 -0800 From: "Derek J. Clark" To: Rong Zhang , =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= , Hans de Goede CC: Mark Pearson , Armin Wolf , Jonathan Corbet , Kurt Borja , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_5/6=5D_platform-x86=3A_lenovo-w?= =?US-ASCII?Q?mi-other=3A_Rename_LWMI=5FOM=5FFW=5FATTR=5FBASE=5FPATH?= User-Agent: Thunderbird for Android In-Reply-To: <239e134c7530004cc004233cb292851ea6864590.camel@rong.moe> References: <20260224043200.2680384-1-derekjohn.clark@gmail.com> <20260224043200.2680384-6-derekjohn.clark@gmail.com> <239e134c7530004cc004233cb292851ea6864590.camel@rong.moe> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On February 25, 2026 9:25:45 AM PST, Rong Zhang wrote: >Hi Derek, > >On Tue, 2026-02-24 at 04:31 +0000, Derek J=2E Clark wrote: >> In the next patch a power supply extension is added which requires >> a name attribute=2E Instead of creating another const macro with the >> same information, replace LWMI_OM_FW_ATTR_BASE_PATH with >> LWMI_OM_NAME and use that for firmware attributes and power supply >> extension=2E >>=20 >> Reviewed-by: Mark Pearson >> Signed-off-by: Derek J=2E Clark >> --- >> drivers/platform/x86/lenovo/wmi-other=2Ec | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >>=20 >> diff --git a/drivers/platform/x86/lenovo/wmi-other=2Ec b/drivers/platfo= rm/x86/lenovo/wmi-other=2Ec >> index 67768f6a50e0=2E=2E7f0d5a17b44f 100644 >> --- a/drivers/platform/x86/lenovo/wmi-other=2Ec >> +++ b/drivers/platform/x86/lenovo/wmi-other=2Ec >> @@ -90,13 +90,13 @@ enum lwmi_feature_id_gpu { >> #define LWMI_FAN_NR 4 >> #define LWMI_FAN_ID(x) ((x) + LWMI_FAN_ID_BASE) >> =20 >> +#define LWMI_FAN_DIV 100 >> + >> #define LWMI_ATTR_ID_FAN_RPM(x) \ >> LWMI_ATTR_ID(LWMI_DEVICE_ID_FAN, LWMI_FEATURE_ID_FAN_RPM, \ >> LWMI_GZ_THERMAL_MODE_NONE, LWMI_FAN_ID(x)) >> =20 >> -#define LWMI_FAN_DIV 100 > >I placed it here intentionally as it has nothing to do with >LWMI_ATTR_ID (contrary to other fan-related macros) and is just a >descriptive macro=2E Understandable=2E I think it makes sense to keep the fan related defines a= ll together since I'll be adding additional LWMI_ATTR_ID defines here later= =2E >> - >> -#define LWMI_OM_FW_ATTR_BASE_PATH "lenovo-wmi-other" >> +#define LWMI_OM_SYSFS_NAME "lenovo-wmi-other" >> #define LWMI_OM_HWMON_NAME "lenovo_wmi_other" >> =20 >> static BLOCKING_NOTIFIER_HEAD(om_chain_head); >> @@ -1233,8 +1233,7 @@ static int lwmi_om_fw_attr_add(struct lwmi_om_pri= v *priv) >> =20 >> priv->fw_attr_dev =3D device_create(&firmware_attributes_class, NULL, >> MKDEV(0, 0), NULL, "%s-%u", >> - LWMI_OM_FW_ATTR_BASE_PATH, >> - priv->ida_id); >> + LWMI_OM_SYSFS_NAME, priv->ida_id); >> if (IS_ERR(priv->fw_attr_dev)) { >> err =3D PTR_ERR(priv->fw_attr_dev); >> goto err_free_ida; > >Thanks, >Rong