From: Jessica Clarke <jrtc27@jrtc27.com>
To: Vineet Gupta <vineetg@rivosinc.com>
Cc: linux-riscv <linux-riscv@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>, Guo Ren <guoren@kernel.org>,
Greentime Hu <greentime.hu@sifive.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux@rivosinc.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] riscv: elf: add .riscv.attributes parsing
Date: Wed, 11 Jan 2023 00:29:49 +0000 [thread overview]
Message-ID: <A2A77A5F-0322-4BFA-A163-33E373C819F7@jrtc27.com> (raw)
In-Reply-To: <3e91a775-c671-35e8-0966-3ec9d8999e14@rivosinc.com>
On 10 Jan 2023, at 23:45, Vineet Gupta <vineetg@rivosinc.com> wrote:
> On 1/10/23 15:21, Jessica Clarke wrote:
>>>> You also should handle more than one sub-subsection even if tools don’t
>>>> emit it today.
>>> Just to be on same page, a sub-section implies the following
>>>
>>> uint32:len, NTBS:vendor-name, uint8: Tag_file, uint32:data-len, <tag><value>....
>>>
>>> If so, the code does support multiple of these
>> That’s a sub-section, but I said sub-subsection.
>
> The psABI documentation that we reviewed yesterday only mentions Tag_File = 1 and doesn't mention the term sub-subsection at all.
> We need to be consistent between code and the new documentation or just add reference to ARM documentation which covers everything and write the general purpose parser.
Documentation you wrote and hasn’t been approved by anyone else. Where
I said that we need to document that multiple sub-subsections are
allowed.
Jess
next prev parent reply other threads:[~2023-01-11 0:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 20:18 Vineet Gupta
2023-01-10 20:48 ` Jessica Clarke
2023-01-10 21:50 ` Vineet Gupta
2023-01-10 23:21 ` Jessica Clarke
2023-01-10 23:45 ` Vineet Gupta
2023-01-11 0:29 ` Jessica Clarke [this message]
2023-01-10 22:04 ` Conor Dooley
2023-01-10 22:16 ` Vineet Gupta
2023-01-10 22:29 ` Conor Dooley
2023-01-11 16:53 ` Eric W. Biederman
2023-01-12 20:22 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2A77A5F-0322-4BFA-A163-33E373C819F7@jrtc27.com \
--to=jrtc27@jrtc27.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=ebiederm@xmission.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@rivosinc.com \
--cc=lkp@intel.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®