From: Anton Altaparmakov <anton@tuxera.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntfs: kernel-doc warning fixes
Date: Fri, 4 Jul 2014 21:21:55 +0100 [thread overview]
Message-ID: <A2B2CD07-AC72-48F0-8176-E25A39F2850A@tuxera.com> (raw)
In-Reply-To: <1404503598-32536-1-git-send-email-fabf@skynet.be>
Hi,
Looks good, thanks. Feel free to add:
Acked-by: Anton Altaparmakov <anton@tuxera.com>
Andrew, could you please take it in your tree for merging?
Thanks a lot in advance!
Best regards,
Anton
On 4 Jul 2014, at 20:53, Fabian Frederick <fabf@skynet.be> wrote:
> cached_page and lru_pvec were removed from
> ntfs_attr_extend_initialized in commit 2ec93b0bf35f
> ("ntfs: clean up ntfs_attr_extend_initialized")
>
> lru_pvec has been removed from __ntfs_grab_cache_pages in commit 4c99000ac47c
> ("ntfs: use add_to_page_cache_lru()")
>
> Cc: Anton Altaparmakov <anton@tuxera.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-ntfs-dev@lists.sourceforge.net
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/ntfs/file.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index 5c9e2c8..f5ec1ce 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -74,8 +74,6 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
> * ntfs_attr_extend_initialized - extend the initialized size of an attribute
> * @ni: ntfs inode of the attribute to extend
> * @new_init_size: requested new initialized size in bytes
> - * @cached_page: store any allocated but unused page here
> - * @lru_pvec: lru-buffering pagevec of the caller
> *
> * Extend the initialized size of an attribute described by the ntfs inode @ni
> * to @new_init_size bytes. This involves zeroing any non-sparse space between
> @@ -395,7 +393,6 @@ static inline void ntfs_fault_in_pages_readable_iovec(const struct iovec *iov,
> * @nr_pages: number of page cache pages to obtain
> * @pages: array of pages in which to return the obtained page cache pages
> * @cached_page: allocated but as yet unused page
> - * @lru_pvec: lru-buffering pagevec of caller
> *
> * Obtain @nr_pages locked page cache pages from the mapping @mapping and
> * starting at index @index.
> --
> 1.9.1
>
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
prev parent reply other threads:[~2014-07-04 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 19:53 Fabian Frederick
2014-07-04 20:21 ` Anton Altaparmakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2B2CD07-AC72-48F0-8176-E25A39F2850A@tuxera.com \
--to=anton@tuxera.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®