From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28FFC4708E for ; Tue, 6 Dec 2022 00:37:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233029AbiLFAhd (ORCPT ); Mon, 5 Dec 2022 19:37:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232604AbiLFAg7 (ORCPT ); Mon, 5 Dec 2022 19:36:59 -0500 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D7AE22B3D for ; Mon, 5 Dec 2022 16:35:44 -0800 (PST) Received: by mail-qt1-x835.google.com with SMTP id a27so12690741qtw.10 for ; Mon, 05 Dec 2022 16:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20210112.gappssmtp.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ne2kQ17Z3A3jdHPo12NzWN07bL28Bd+Tg02BrzT7QcM=; b=8B7MCsObOOvSR6mCIokEm9+fr1yaDvUvjD7xLGijdBTs3173zrpzOBCSMq7GbxNBOM jlA32HML4qaWiA3bC6/MPSgXaUVCfDcNO6Eh0Y0wkVZv0g1YdCxC7+6gaO3SEVPZoGb5 HrrRV5vE7unUe9agoAJ8B1Pp8NbAhAYjBb9QhoDja4o0GsDM0tFW8pGusiEyqX4zxzkF CljQBwGY9gpwXG1kIXBI+qeSYEVIsVEySuVkFdkM0H9hKa0A4GvD1jan7GRU9WkJps92 YP/pq8joOPnl2SuuUW4hLh9dHzTeG3C8HOQaTrrE/uf+/pB8p30p04rCt3j/O4H92pqq BKMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ne2kQ17Z3A3jdHPo12NzWN07bL28Bd+Tg02BrzT7QcM=; b=yQObrtHsg1jmP/uL/XxMlPX4BdsM5qIZ5RRW1ntooNXWkh4LwGyc3GKEYmMPlR5COM S1rN20r82BTqh1CulBa0yuWyGQ7DHxRfcySvpy1IpYd3WoXPdpU6HKCP5kCD7M2KVRMi PMfvyGoyuF0LKRdIsqtF2Xdcq3ibwEOdZNfQwl+gsTc9SeoxSq1L4BACg8L7HNQy8orr pfoZ1VTSbfsBcMdR+sfJkxcVNbcjQLdhiteU570Tjxslz06IthqCWcyIRcxwwdmLIH4U Ut+IiYfUWqLXKoqn+aqe1wTsK44jqo/umX4JDW21IsvrB55NWDrL67OTCaC4AdBIwY9Q hP3Q== X-Gm-Message-State: ANoB5plaUTtoYF9cYNz/AeskNyaxatLOhZkKzud9AaifsRKmbA5H7kWk DmAhxds/CEGj0Avb3MVOGuw2hA== X-Google-Smtp-Source: AA0mqf6Oos0yfJkVZaqeYo7679Myu1FELMEk7IoUBQqnjFE3jKyqOBdEBqH00X3hxXMU9cg1xpS1Kw== X-Received: by 2002:ac8:4d4f:0:b0:3a6:1dea:8c1c with SMTP id x15-20020ac84d4f000000b003a61dea8c1cmr68663245qtv.157.1670286942302; Mon, 05 Dec 2022 16:35:42 -0800 (PST) Received: from smtpclient.apple (172-125-78-211.lightspeed.sntcca.sbcglobal.net. [172.125.78.211]) by smtp.gmail.com with ESMTPSA id 134-20020a37088c000000b006ec771d8f89sm327312qki.112.2022.12.05.16.35.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2022 16:35:41 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] hfsplus: Fix bug causing custom uid and gid being unable to be assigned with mount From: Viacheslav Dubeyko In-Reply-To: <1D7AAEE4-9603-43A4-B89D-6F791EDCB929@live.com> Date: Mon, 5 Dec 2022 16:35:36 -0800 Cc: "willy@infradead.org" , "ira.weiny@intel.com" , "axboe@kernel.dk" , "akpm@linux-foundation.org" , "bvanassche@acm.org" , "keescook@chromium.org" , "songmuchun@bytedance.com" , "torvalds@linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <93F5197D-2B61-4129-B5D4-771934F70577@live.com> <55A80630-60FB-44BE-9628-29104AB8A7D0@dubeyko.com> <1D7AAEE4-9603-43A4-B89D-6F791EDCB929@live.com> To: Aditya Garg X-Mailer: Apple Mail (2.3696.120.41.1.1) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Dec 2, 2022, at 11:56 PM, Aditya Garg = wrote: >=20 >=20 >> Also, what if we mounted >> file system without specifying the UID/GID, then what UID/GID will be = returned by >> your logic? >=20 > So this case is if I run =E2=80=9Csudo mount /dev/sda1 /mnt=E2=80=9D >=20 > Here the driver will not do any spoofing, and the real owners of the = files shall be displayed. Thus running =E2=80=9Cls -l=E2=80=9D on a = mounted partition without specifying UID/GID, files written by macOS = shall be shown as 99 as the owner, iPadOS as 501, and if any file was = written on Linux, the user who wrote it will be the owner. >=20 > If the user/group of any file was changed using chown, then the new = user/group of the file will be displayed. My question is much more simple. diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index aeab83ed1..4d1077db8 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c @@ -192,11 +192,11 @@ static void hfsplus_get_perms(struct inode *inode, mode =3D be16_to_cpu(perms->mode); i_uid_write(inode, be32_to_cpu(perms->owner)); - if (!i_uid_read(inode) && !mode) + if (test_bit(HFSPLUS_SB_UID, &sbi->flags)) inode->i_uid =3D sbi->uid; i_gid_write(inode, be32_to_cpu(perms->group)); - if (!i_gid_read(inode) && !mode) + if (test_bit(HFSPLUS_SB_GID, &sbi->flags)) inode->i_gid =3D sbi->gid; Before this change, logic called i_uid_read(inode) and checked mode. Now, we check only HFSPLUS_SB_UID/HFSPLUS_SB_GID flags. So, if we mount HFS+ volume by =E2=80=9Csudo mount /dev/sda1 /mnt=E2=80=9D= , then HFSPLUS_SB_UID and HFSPLUS_SB_GID flags will be unset. And current logic will do nothing. Is it correct logic? Maybe, we need to use sbi->uid/gid if flag(s)HFSPLUS_SB_UID/HFSPLUS_SB_GID are set. And if not, then to use old logic. Am I correct here? Or am I still = missing something here? Thanks, Slava.