From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966119AbcHBN6z (ORCPT ); Tue, 2 Aug 2016 09:58:55 -0400 Received: from ipv4.connman.net ([82.165.8.211]:54488 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966888AbcHBN61 convert rfc822-to-8bit (ORCPT ); Tue, 2 Aug 2016 09:58:27 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH 0063/1285] Replace numeric parameter like 0444 with macro From: Marcel Holtmann In-Reply-To: <20160802131937.GB11666@home.goodmis.org> Date: Tue, 2 Aug 2016 15:58:10 +0200 Cc: Sergei Shtylyov , Baole Ni , Bartlomiej Zolnierkiewicz , tj@kernel.org, lenb@kernel.org, X86 ML , hpa@zytor.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, travis@sgi.com Content-Transfer-Encoding: 8BIT Message-Id: References: <20160802103759.17958-1-baolex.ni@intel.com> <5391e340-1285-574d-1979-a19571341eb5@cogentembedded.com> <20160802131937.GB11666@home.goodmis.org> To: Steven Rostedt X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, >>>> static int all; >>>> -module_param(all, int, 0444); >>>> +module_param(all, int, S_IRUSR | S_IRGRP | S_IROTH); >>> >>> There's S_IRUGO for this case, no? > > Sure, and honestly, I understand what 0444 is better than seeing: > > S_IRUSR | S_IRGRP | SIROTH > > Heck, 0444 is more understandable to me than S_IRUGO, because honestly, those > macros are just as cryptic as 0444 is. Working with Unix/Linux systems since > 1991, I understand the octo numbers very well. And I'm sure most other people > do to. Any file that I'm Cc'd on here will get an automatic NAK from me. you are not helping to reduce the 1285 patch bomb. Your automatic replies make it worse now ;) Regards Marcel