From: Marcel Holtmann <marcel@holtmann.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT
Date: Tue, 14 Jul 2015 17:29:17 +0200 [thread overview]
Message-ID: <A2E649D0-855C-4DBC-8A23-7D2CF2747530@holtmann.org> (raw)
In-Reply-To: <1436825494.20249.47.camel@hadess.net>
Hi Bastien,
> http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu
> s=127896
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
>
> ---
> net/rfkill/rfkill-gpio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
> index d5d58d9..9471024 100644
> --- a/net/rfkill/rfkill-gpio.c
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -168,6 +168,7 @@ static const struct acpi_device_id
> rfkill_acpi_match[] = {
> { "BCM2E3D", RFKILL_TYPE_BLUETOOTH },
> { "BCM2E40", RFKILL_TYPE_BLUETOOTH },
> { "BCM2E64", RFKILL_TYPE_BLUETOOTH },
> + { "OBDA8723", RFKILL_TYPE_BLUETOOTH },
> { "BCM4752", RFKILL_TYPE_GPS },
> { "LNV4752", RFKILL_TYPE_GPS },
> { },
while this is most likely a good start to get people going and testing the hardware, I think long-term some these IDs have to move out of this driver and into a Realtek specific UART slave driver (once we get such a thing upstream).
I think one example would be what Fred is currently doing for the Broadcom UART devices. Essentially we are currently misusing the RFKILL switch for an on/off switch of the GPIO lines. This would be better handled by the Bluetooth subsystem itself when you power on the controller.
Regards
Marcel
next prev parent reply other threads:[~2015-07-14 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 22:11 Bastien Nocera
2015-07-14 13:20 ` Larry Finger
2015-07-14 13:21 ` Johannes Berg
2015-07-15 6:32 ` Bastien Nocera
2015-07-20 5:34 ` Kalle Valo
2015-07-15 6:30 ` Bastien Nocera
2015-07-14 15:29 ` Marcel Holtmann [this message]
2015-07-15 6:27 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2E649D0-855C-4DBC-8A23-7D2CF2747530@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=hadess@hadess.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®