From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D4CC61CE4 for ; Sat, 19 Jan 2019 22:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E86162084C for ; Sat, 19 Jan 2019 22:28:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=appneta.com header.i=@appneta.com header.b="MbFCpp8P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729820AbfASW2X (ORCPT ); Sat, 19 Jan 2019 17:28:23 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38736 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729618AbfASW2X (ORCPT ); Sat, 19 Jan 2019 17:28:23 -0500 Received: by mail-pf1-f194.google.com with SMTP id q1so8347961pfi.5 for ; Sat, 19 Jan 2019 14:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=appneta.com; s=google; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=C2gdubuL8B3G5DwsLe3mTliXcK2KJqdndFdz0Tu9BOg=; b=MbFCpp8PMdI4KBf4cefksy7WyjoABw9NbJ3lDPKG5Swp7SiGCXmd6G8veVAVzaOGHi M0f1vwlvQsmzCRmODRcuHO5WBXfACQ3UU/6mmXPiVcjSUmHRtT8Jzc9zM6qGasyeVf1A 0XWnQLSZDdq5NsfhBvKO5kB7pd7TF6foIqdY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=C2gdubuL8B3G5DwsLe3mTliXcK2KJqdndFdz0Tu9BOg=; b=KcoLJfKRuxQoMroj3EBMan3e+TnhDRHEzSOk95kmh40eA6hrSISGvC1AFu0VSOVFch RQj7ly4NGGZZ6P30lstI8jCm7WnYw6xbenUFCDQ7CvSqAkmPHtPMp20XsPuvvW4tL9t5 Bu+DfdVrqdygLmVSecVNDMQI/3BI4jheRRz2hM2aAA93p6tEO8BvYsfdwvZmg+ZJI7jp ha/ADCgbUWvvdnDEYVqA7vKQ/qvdYakwETv9EkbYb1JrLzMRubWKD+PQb2tKXFFGC2uM qRnbSMnNIW4/jhN225I9xZfYtk+EqEOYegniFCXuoL59iJi1Ow6rlctKDEBTGzOrMdva SEMQ== X-Gm-Message-State: AJcUukeJUtVI33r2WhGRzcOd2aOMpMsI3Yuc+xk/9cbWS/a5fnnv8ghi BIeCp/zkinzEJccxs8dGZ19kfg== X-Google-Smtp-Source: ALg8bN7kycGUCHfvCPoR89tvkS3QbjCNPvT3HKyF55jAPnCt6nTLrjQd9oxgBmUDWEPmhvsZq7JbRQ== X-Received: by 2002:a63:2744:: with SMTP id n65mr22774825pgn.65.1547936901827; Sat, 19 Jan 2019 14:28:21 -0800 (PST) Received: from [10.0.1.12] (S010620c9d00fc332.vf.shawcable.net. [70.71.167.160]) by smtp.gmail.com with ESMTPSA id t90sm12365672pfj.23.2019.01.19.14.28.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 14:28:20 -0800 (PST) From: Fred Klassen Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [PATCH v2] ipmi: Prevent use-after-free in deliver_response Message-Id: Date: Sat, 19 Jan 2019 14:28:18 -0800 To: "Corey Minyard (supporter:IPMI SUBSYSTEM)" , "Arnd Bergmann (supporter:CHAR and MISC DRIVERS)" , "Greg Kroah-Hartman (supporter:CHAR and MISC DRIVERS)" , "moderated list:IPMI SUBSYSTEM" , open list X-Mailer: Apple Mail (2.3445.102.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some IPMI modules (e.g. ibmpex_msg_handler()) will have ipmi_usr_hdlr handlers that call ipmi_free_recv_msg() directly. This will essentially kfree(msg), leading to use-after-free. This does not happen in the ipmi_devintf module, which will queue the message and run ipmi_free_recv_msg() later. BUG: KASAN: use-after-free in deliver_response+0x12f/0x1b0 Read of size 8 at addr ffff888a7bf20018 by task ksoftirqd/3/27 CPU: 3 PID: 27 Comm: ksoftirqd/3 Tainted: G O = 4.19.11-amd64-ani99-debug #12.0.1.601133+pv Hardware name: AppNeta r1000/X11SPW-TF, BIOS 2.1a-AP 09/17/2018 Call Trace: dump_stack+0x92/0xeb print_address_description+0x73/0x290 kasan_report+0x258/0x380 deliver_response+0x12f/0x1b0 ? ipmi_free_recv_msg+0x50/0x50 deliver_local_response+0xe/0x50 handle_one_recv_msg+0x37a/0x21d0 handle_new_recv_msgs+0x1ce/0x440 ... Allocated by task 9885: kasan_kmalloc+0xa0/0xd0 kmem_cache_alloc_trace+0x116/0x290 ipmi_alloc_recv_msg+0x28/0x70 i_ipmi_request+0xb4a/0x1640 ipmi_request_settime+0x1b8/0x1e0 ... Freed by task 27: __kasan_slab_free+0x12e/0x180 kfree+0xe9/0x280 deliver_response+0x122/0x1b0 deliver_local_response+0xe/0x50 handle_one_recv_msg+0x37a/0x21d0 handle_new_recv_msgs+0x1ce/0x440 tasklet_action_common.isra.19+0xc4/0x250 __do_softirq+0x11f/0x51f Fixes: e86ee2d44b44 ("ipmi: Rework locking and shutdown for hot remove") Cc: stable@vger.kernel.org Signed-off-by: Fred Klassen --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c = b/drivers/char/ipmi/ipmi_msghandler.c index 7fc9612070a1..fbf93c2d6c05 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -883,7 +883,7 @@ static int deliver_response(struct ipmi_smi *intf, = struct ipmi_recv_msg *msg) if (user) { user->handler->ipmi_recv_hndl(msg, = user->handler_data); - release_ipmi_user(msg->user, index); + release_ipmi_user(user, index); } else { /* User went away, give up. */ ipmi_free_recv_msg(msg); --=20 2.11.0=