From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: "Koenig, Christian" <Christian.Koenig@amd.com>,
David Airlie <airlied@linux.ie>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drm/radeon: remove unreachable code
Date: Mon, 19 Jan 2015 18:27:23 +0000 [thread overview]
Message-ID: <A3397C8B8B789E45844E7EC5DEAD89D0635F03CC@satlexdag05.amd.com> (raw)
In-Reply-To: <1421673040-12305-1-git-send-email-der.herr@hofr.at>
> -----Original Message-----
> From: Nicholas Mc Guire [mailto:der.herr@hofr.at]
> Sent: Monday, January 19, 2015 8:11 AM
> To: Deucher, Alexander
> Cc: Koenig, Christian; David Airlie; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org; Nicholas Mc Guire
> Subject: [PATCH] drm/radeon: remove unreachable code
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
NACK. I want to leave this in place for the future. When we support dynamically adjusting the disp clock we'll need to update the sclk for ds mode.
Alex
> ---
>
> As the if (CISLAND_MINIMUM_ENGINE_CLOCK !=
> CISLAND_MINIMUM_ENGINE_CLOCK) is never
> satisfied - the entire else branch is never going to be executed and could be
> removed - provided this is not simply a bug and needs to be fixed...
>
> Patch is against 3.19.0-rc5 -next-20150119
>
> Patch was only compile tested with x86_64_defconfig + CONFIG_DRM=m,
> CONFIG_DRM_RADEON=m
>
> drivers/gpu/drm/radeon/ci_dpm.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/ci_dpm.c
> b/drivers/gpu/drm/radeon/ci_dpm.c
> index f373a81..28db529 100644
> --- a/drivers/gpu/drm/radeon/ci_dpm.c
> +++ b/drivers/gpu/drm/radeon/ci_dpm.c
> @@ -3805,13 +3805,8 @@ static void
> ci_find_dpm_states_clocks_in_dpm_table(struct radeon_device *rdev,
> break;
> }
>
> - if (i >= sclk_table->count) {
> + if (i >= sclk_table->count)
> pi->need_update_smu7_dpm_table |=
> DPMTABLE_OD_UPDATE_SCLK;
> - } else {
> - /* XXX check display min clock requirements */
> - if (CISLAND_MINIMUM_ENGINE_CLOCK !=
> CISLAND_MINIMUM_ENGINE_CLOCK)
> - pi->need_update_smu7_dpm_table |=
> DPMTABLE_UPDATE_SCLK;
> - }
>
> for (i = 0; i < mclk_table->count; i++) {
> if (mclk == mclk_table->dpm_levels[i].value)
> --
> 1.7.10.4
next prev parent reply other threads:[~2015-01-19 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 13:10 Nicholas Mc Guire
2015-01-19 18:27 ` Deucher, Alexander [this message]
2015-01-20 0:25 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A3397C8B8B789E45844E7EC5DEAD89D0635F03CC@satlexdag05.amd.com \
--to=alexander.deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=airlied@linux.ie \
--cc=der.herr@hofr.at \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®