From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754504AbcFAQJ5 (ORCPT ); Wed, 1 Jun 2016 12:09:57 -0400 Received: from mail-by2on0099.outbound.protection.outlook.com ([207.46.100.99]:33128 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750727AbcFAQJ4 convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 12:09:56 -0400 From: "Huang, Ray" To: Guenter Roeck CC: Borislav Petkov , "linux-hwmon@vger.kernel.org" , X86 ML , LKML , "Hurwitz, Sherry" Subject: Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers Thread-Topic: [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers Thread-Index: AQHRu+0Pzf+Hx7vl6UuWGyZeyW4SdJ/UmZSAgAAipbiAAAJZWw== Date: Wed, 1 Jun 2016 15:35:23 +0000 Message-ID: References: <1464775486-23446-1-git-send-email-bp@alien8.de>,<574EE1B3.9010704@roeck-us.net>,<5FE1E570-430B-4C0D-9100-E213D5B5ACFA@amd.com> In-Reply-To: <5FE1E570-430B-4C0D-9100-E213D5B5ACFA@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=none action=none header.from=amd.com; x-originating-ip: [117.41.146.210] x-ms-office365-filtering-correlation-id: d8ddbc1f-18b3-46ed-8f12-08d38a325907 x-microsoft-exchange-diagnostics: 1;DM2PR12MB0063;5:OMKjgX08T4m3uAyeYI7HEX0qN/UYEhd1icCNDlV6b16f74PTyWAE4wL4o9tofgL8sh9SrRWg+So2tIRWfN+irENVuG9QMIkjXpUgzW+z6doaPebeVCn4HRG9+rDr5IaJt2H08RChOLxExDf0/UjcDQ==;24:2UHSKFfhxPKOP8FEZjT+nrIUzW+OFGdkK6h/GOYBaV77OjgvLXxv63UhV7I++Y2/+nwzsUVkp6gc2kB4BeUbSTKpy9ojPoKb1N03Zmg3NcY=;7:F+LZ4HxiklGChaeEAjmY2Cq90u23pghTK9KWRbUeNpPjNMw2UVoKlqdr4GF6JuDtztcYx3XFNZV3UPg8lFxxdmdiiPgxYadlYPOada+7H5BHuABJYGDB7OL6WpDxevUFplq3lKZv7KFN6PY7B2gXU1mTJoDW4f+aOzfyTOEK9FI=;20:OlLZZWLAJ4SYVcnceaJNyVF9/3W8JU6Jx5OmER1CgxT8wDy16ovYJDUT7YxpucZLWA2TKSXBAz4z/7KRENmExcNSINPQs3TMY/jodr9dAdq/A/fLtLjZaTG7yPBj17dyDAib8bd51PC7Bvz5qsfYUOcKADDLLQmrJoUkQDP97o44c/xd7+iGku7yn7NGoefZV8aDXZSYXkyXSnZkPOkTFB8yBoqC96tNUTGoEr5LCDunltvYgOAiLZCNSdJ+x53m x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR12MB0063; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DM2PR12MB0063;BCL:0;PCL:0;RULEID:;SRVR:DM2PR12MB0063; x-forefront-prvs: 096029FF66 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(24454002)(99286002)(3660700001)(2906002)(8676002)(4326007)(106116001)(110136002)(77096005)(3280700002)(5002640100001)(19580395003)(189998001)(82746002)(19580405001)(81166006)(83716003)(5003630100001)(10400500002)(87936001)(122556002)(11100500001)(33656002)(5008740100001)(86362001)(102836003)(92566002)(2950100001)(36756003)(2900100001)(3846002)(6116002)(66066001)(76176999)(8936002)(586003)(50986999)(54356999)(5004730100002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0063;H:DM2PR12MB0016.namprd12.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2016 15:35:23.4006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0063 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sent from my iPad > On Jun 1, 2016, at 11:27 PM, Huang, Ray wrote: > > > >>> On Jun 1, 2016, at 9:23 PM, Guenter Roeck wrote: >>> >>> On 06/01/2016 03:04 AM, Borislav Petkov wrote: >>> From: Borislav Petkov >>> >>> We need to read a bunch of registers on each compute unit and possibly >>> on the current CPU too. Disable preemption around it. >> >> An explanation would be helpful. Is this a bug fix ? I would like to get >> a confirmation from someone at AMD that this is really necessary. >> > > This change looks good for me. But I am in office this week, I will test it on CZ platform next week. :-) Sorry, fix typo. I am *not* in office this week. Rui