From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793096549; b=CJC1w6xb0Q+fIBdqv7K5aKz4O4dlq0rIctfN/u5rbp8bVlR+AG28N+xKtxHIjrg1MLQZ WiJd4IThjkMasXD0VsiFwQHAKBDUILZfAAFwIzd11Iw5L9HqEq1Fw+h0v+JnEj5Mr7CC0 UCSk9IRRs8vkVwr0wUUPIfEq17+pCivGfnqgC1UrGqcrjb0+d5+ZCdCK8vchxzzsbiIO0 j7GBwbVaxyYNymbryW4g2d90YsV2g4yxA5fW8fQ9W85am3czaFuAY52vWxw4mHVqOanjo Kc9X9B/+OWrFTRC0JwLoqeedmq1P1qYE5p1tMqctFZhQu8KFv+l2iNW5nmbOjBWbbUA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793096549; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; bh=Txz3OjJcCusHpkz1mnsFRsjrPbuP5hB0e5979S9csEw=; b=zVTPx4fyqkzk0PE6h0P6yRPOOw2JPqQjibp32fyRdzfCYtM4xEEIhD2xUu9hO+Tpw+z2 0oamolqKHcra6SW4hzadmwwQXw2PU+cyLXJn+zWd4CHilJeOzpUgYE+ahm8p9fNBzwN8J 46xfSWvvIZ7M+kMxzrcHB6/OBqWybwVjhzEq/iGv/Ef20dHEttltZrS577RII6G6Byg2d i7BEKuNyCU3RdIWQ5XeOmuDkRXcVD/5Icj84d0fH4cNw+omPYX3qmMaKntLNR0+H7GSJ2 Q7z5NwDE/CFgeQFjKqjQ+XsQ8VeJJodsmidFT3OEDeI6ef7nqOUWUBWy2PKESDTkiUg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=PRuyvpw0; arc=none smtp.remote-ip=209.85.128.41 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F12D606A31F for ; Tue, 27 Oct 2026 10:22:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0F12D606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=PRuyvpw0 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4a35db1f202so22033995e9.3 for ; Tue, 27 Oct 2026 03:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793096547; x=1793701347; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Txz3OjJcCusHpkz1mnsFRsjrPbuP5hB0e5979S9csEw=; b=PRuyvpw09AXUhxaqoKSn35lLtPWxMtTHN4GQ32Ex6SVZaLabRSVb6RMYIY5MIg5472 Y21PXceAqe42yrKRyJUq60g3sTXY+cQvLfgRLC+eblPmGWtUc/yYHsyf+6QEetzx5pLd mDJGFc5pP7iWYBYbeGGFHu0o2HpM5oYrVZX9a2Uy4BAwmhkTCB7tMBmLK3soa13XGKnx QkBlNFeA2FnfdG2NVVT4T5s+mMNk+Hhgyi418fm5yPTg1ytt3IiWE9iaa88WGiyvjk/T aB9/DQkSPRi9hMKw99M6ChHLh9sgdtCpjKBi3u70cpl5PwzDywNX7roYNXKz3h9HO/EQ PnNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793096547; x=1793701347; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Txz3OjJcCusHpkz1mnsFRsjrPbuP5hB0e5979S9csEw=; b=vpjKAXfqT9uIzy8brMwon4hawYfBm9+q0D/gLwAHZ4NpwqBPTvUj+N0QUsgu9PSNJr RqJJIEDMKFoQQNwfdzB71O/OLyJ1J4haakoest73r0VRF+2F71Umk4TA0pzsP2nDxl6a bBuQoVK9pe7js/SGbhvbeOp9O/WulTjM2+zzaNF4Cs3F74cLK4H2r9tMa+cWmD43C/tI CfOjYWlnUB8y5x2uc+BAtk2LnTCeaOYubQgV7cZk00Rwers3aoQ5fBr91gocdCJUPr4V 0AkWsgnJGO0VXR2MvLEo701g7a1/83+PxHQ/Ka8eJX7NtYnW4rqHgX2X7/b8rwecK2OP gxVA== X-Forwarded-Encrypted: i=1; AKwUvByY1ju935ZqrLuolMzsskp27sKpYY2Sz66t0BJDZCpqA1YJ08ib7Z/n4ht/t028R+2Ni2i9YmUT/kUdWq8=@vger.kernel.org X-Gm-Message-State: AFq9FYJ6kSCC3LmC+O+LRvDHeCeQC3R8SfA0l8BXiaxi6T5x7FMeV2ht MyMLWZskNRMJkdmy7hLEOBw/FboryH6SH2fswaJ7ESmiafzDj/TdrwJ5 X-Gm-Gg: AYBFou23EPUd35/nntks5xrDRDvABf7jtv3kE/MM5qGF7BryG6H7bSFct8qRU6QonWX 07O/VeZBMwCQ4WenlTRxlklTt1lIcF08qJXyqhQ+Et840cbVHI5s7HYVicHx+664pBgUByKQMeD 5q+T0YILLonZaBl4/Sov5/UyfdT/AFQAmTOXMV1nMu7L58sRys0h2BVGh3l1u9X4tuEF8hio1nb y2R/h1WY6a3Ur3jb5TWUcsfgPp0pLE0oPatEtuigHVpFXqp+yIPh3Brh+bmpgdx0EmAvp8PKIOA IB9sPpaHOrIBuKM36yCEq96DtZLf3s2ETDJSjDVg6R3ZIe4DCQZJYZH1v6LdU8EI02/9OTPdeis GXCIz/eSHeHvo6piPJuer7gg6h3/dGQe59leloUzAtbd468wvSsyrjTKSta3Nckgc53Rspb5YDG eHScd69rZyG1sKORu7iIuvuTtOFuYaIs8m4J0ZZTsyGG07olcts1X/c+SOF80gF+47g2lrimDSK EDIQZJ2g45OAYQNYoVWxBihE4s8kuio/rNgi2Yqx7UJTTGVW73VoPUVLl9MD+1F/hO/VFZsQC7g NVxOAT6fQg== X-Received: by 2002:a05:600c:4e12:b0:4a1:702f:c736 with SMTP id 5b1f17b1804b1-4a35ac3f7bdmr182539685e9.3.1793096547086; Tue, 27 Oct 2026 03:22:27 -0700 (PDT) Received: from smtpclient.apple ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ebd4be6sm20023565f8f.37.2026.10.27.03.22.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2026 03:22:25 -0700 (PDT) Content-Type: text/plain; charset=utf-8 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: [PATCH 4/4] cpufreq: add an Amlogic speed-bin driver From: Christian Hewitt In-Reply-To: <9556e959-daf3-4c85-8794-9613e7e7a9ae@gmail.com> Date: Tue, 27 Oct 2026 14:22:09 +0400 Cc: Viresh Kumar , Jerome Brunet , christian.koever-draxl@student.uibk.ac.at, neil.armstrong@linaro.org, sboyd@kernel.org, bmasney+clk@redhat.com, khilman@baylibre.com, martin.blumenstingl@googlemail.com, rafael@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?Q?Christian_Stefan_K=C3=B6v=C3=A9r-Draxl?= Content-Transfer-Encoding: quoted-printable Message-Id: References: <20261025192219.209137-1-christian.koever-draxl@student.uibk.ac.at> <20261025192219.209137-5-christian.koever-draxl@student.uibk.ac.at> <1jbj8gkff1.fsf@starbuckisacylon.baylibre.com> <9556e959-daf3-4c85-8794-9613e7e7a9ae@gmail.com> To: Chuan Liu X-Mailer: Apple Mail (2.3864.700.51.1.3) > On 27 Oct 2026, at 1:26=E2=80=AFpm, Chuan Liu = wrote: >=20 > Hi Viresh, Christian, > Could you please hold off for now on the patches adding cpufreq = driver support on S4? There are still two issues that need to be = resolved first: > - The clock driver currently does not support setting the CPU clock. > - The CPU regulator needs some time to stabilize after the voltage is = changed. Without a proper delay, the CPU clock frequency may be raised = before the regulator voltage has actually reached the target value, = which can hang the system. The S4 CPU regulator handling currently lacks = the logic to wait for the regulator voltage to settle, so this part = needs to be completed first. >=20 > We are currently working on submitting our own cpufreq driver. We are = considering how to address the issues above, taking into account the = hardware characteristics of previous SoCs and evaluating factors such as = the transition latency. S4 will be covered by that work (as well as SoCs = from S4 onward, such as C3, T7, ..., A9). So please give us some time. Please don=E2=80=99t top-post, keep inline threading! FWIW, the recent bindings/clock/driver work I=E2=80=99ve done for S4 is = here: https://github.com/chewitt/linux/commits/amlogic-7.3.y My speed-bin driver is based on earlier work from Martin Blumenstingl: = https://github.com/chewitt/linux/commit/77e12d4d584d6a8bbd93304bbd4e9bbbb6= ee159a Setting a ramp-delay was the key to opp transition stability: = https://github.com/chewitt/linux/commit/ca7a99e86e23677c7b5af887e6f3b3c8ce= 3470d2 CH. also a Christian, to confuse people :) > On 10/26/2026 4:59 PM, Viresh Kumar wrote: >> On 26-10-26, 09:57, Jerome Brunet wrote: >>> On lun. 26 oct. 2026 at 11:00, Viresh Kumar = wrote: >>>=20 >>>> On 25-10-26, 20:22, christian.koever-draxl@student.uibk.ac.at = wrote: >>>>> From: Christian Stefan K=C3=B6v=C3=A9r-Draxl >>>>>=20 >>>>> Every S4 speed bin runs the same CPU frequencies but needs its own >>>>> voltage curve, and the bin can only be read through the secure = monitor. >>>>>=20 >>>>> Read the bin from the firmware, select the matching >>>>> "opp-microvolt-speed" property for all CPUs, then register >>>>> cpufreq-dt. Bins outside the known range fall back to bin 0, which >>>>> has the highest voltages. Like sun50i-cpufreq-nvmem, the driver = binds >>>>> on the SoC compatible and needs no node of its own, and S4 is = added to >>>>> the cpufreq-dt-platdev blocklist so cpufreq-dt is only created = after >>>>> the bin has been applied. >>>>>=20 >>>>> Signed-off-by: Christian Stefan K=C3=B6v=C3=A9r-Draxl = >>>>> --- >>>>> MAINTAINERS | 1 + >>>>> drivers/cpufreq/Kconfig.arm | 14 ++ >>>>> drivers/cpufreq/Makefile | 1 + >>>>> drivers/cpufreq/amlogic-cpufreq.c | 184 = +++++++++++++++++++++++++++ >>>>> drivers/cpufreq/cpufreq-dt-platdev.c | 2 + >>>>> 5 files changed, 202 insertions(+) >>>>> create mode 100644 drivers/cpufreq/amlogic-cpufreq.c >>>>=20 >>>> Is it safe to apply just this one ? I can take this via the PM tree = then. >>>=20 >>> I would advise to wait a little for Amlogic to chime in. >> Sure, I wasn't going to wait for the maintainers to respond anyway. >=20 > --=20 > Best regards, > Chuan >=20 >=20 > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic