mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Tiejun Chen <tiejun.chen@windriver.com>
Cc: <benh@kernel.crashing.org>, <linuxppc-dev@lists.ozlabs.org>,
	<linux-kernel@vger.kernel.org>, <jason.wessel@windriver.com>
Subject: Re: [v1][PATCH 3/6] book3e/kgdb: update thread's dbcr0
Date: Thu, 20 Dec 2012 12:41:53 -0600	[thread overview]
Message-ID: <A47C9236-0744-45BC-B25A-3DDEB05CD8A1@kernel.crashing.org> (raw)
In-Reply-To: <1355994510-11934-4-git-send-email-tiejun.chen@windriver.com>


On Dec 20, 2012, at 3:08 AM, Tiejun Chen wrote:

> gdb always need to generate a single step properly to invoke
> a kgdb state. But with lazy interrupt, book3e can't always
> trigger a debug exception with a single step since the current
> is blocked for handling those pending exception, then we miss
> that expected dbcr configuration at last to generate a debug
> exception.
> 
> So here we also update thread's dbcr0 to make sure the current
> can go back with that missed dbcr0 configuration.
> 
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
> ---
> arch/powerpc/kernel/kgdb.c |   10 ++++++++++
> 1 file changed, 10 insertions(+)
> 
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index c470a40..516b44b 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -426,8 +426,18 @@ int kgdb_arch_handle_exception(int vector, int signo, int err_code,
> 		/* set the trace bit if we're stepping */
> 		if (remcom_in_buffer[0] == 's') {
> #ifdef CONFIG_PPC_ADV_DEBUG_REGS
> +#ifdef CONFIG_PPC_BOOK3E

Should this really be CONFIG_PPC64 or CONFIG_PPC_BOOK3E_64?

> +			/* With lazy interrut we have to update thread dbcr0 here
> +			 * to make sure we can set debug properly at last to invoke
> +			 * kgdb again to work well.
> +			 */
> +			current->thread.dbcr0 =
> +				mfspr(SPRN_DBCR0) | DBCR0_IC | DBCR0_IDM;
> +			mtspr(SPRN_DBCR0, current->thread.dbcr0);
> +#else
> 			mtspr(SPRN_DBCR0,
> 			      mfspr(SPRN_DBCR0) | DBCR0_IC | DBCR0_IDM);
> +#endif

Can we code this so we don't need the #else?

> 			linux_regs->msr |= MSR_DE;
> #else
> 			linux_regs->msr |= MSR_SE;
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2012-12-20 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20  9:08 [v1][PATCH 0/6] powerpc/book3e: make kgdb to work well Tiejun Chen
2012-12-20  9:08 ` [v1][PATCH 1/6] powerpc/book3e: load critical/machine/debug exception stack Tiejun Chen
2012-12-20  9:08 ` [v1][PATCH 2/6] powerpc/book3e: store critical/machine/debug exception thread info Tiejun Chen
2012-12-20  9:08 ` [v1][PATCH 3/6] book3e/kgdb: update thread's dbcr0 Tiejun Chen
2012-12-20 18:41   ` Kumar Gala [this message]
2012-12-21  2:02     ` tiejun.chen
2012-12-20  9:08 ` [v1][PATCH 4/6] book3e/kgdb: Fix a single stgep case of lazy IRQ Tiejun Chen
2012-12-20  9:08 ` [v1][PATCH 5/6] powerpc/book3e: support kgdb for kernel space Tiejun Chen
2012-12-20  9:08 ` [v1][PATCH 6/6] kgdb/kgdbts: support ppc64 Tiejun Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A47C9236-0744-45BC-B25A-3DDEB05CD8A1@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=benh@kernel.crashing.org \
    --cc=jason.wessel@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=tiejun.chen@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®