From: Muchun Song <muchun.song@linux.dev>
To: Mike Rapoport <rppt@kernel.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
Li Zhe <lizhe.67@bytedance.com>,
Andrew Popple <apopple@nvidia.com>,
Balbir Singh <balbirs@nvidia.com>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
James Houghton <jthoughton@google.com>,
Lance Yang <lance.yang@linux.dev>, Qi Zheng <qi.zheng@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/14] mm: Unify memmap initialization for compound pages
Date: Tue, 17 Nov 2026 11:57:22 +0800 [thread overview]
Message-ID: <A4F207DD-9535-42EC-B9A6-88578BFE369B@linux.dev> (raw)
In-Reply-To: <179482576829.2379196.3205677806966393313.b4-review@b4>
> On Nov 16, 2026, at 18:42, Mike Rapoport <rppt@kernel.org> wrote:
>
> Hi,
Hi Mike,
>
>> Hi,
>>
>> This v2 is based on the mm-new branch at commit daed51c91051.
>>
>> This series is split out from the earlier, larger series
>> "mm: Generalize HVO for HugeTLB and device DAX" [1]. That series
>> generalized vmemmap optimization across HugeTLB and device DAX. One
>> remaining piece is the separate compound struct page initialization used
>> by boot-time gigantic HugeTLB pages and compound ZONE_DEVICE ranges.
>>
>> This v2 also folds in Li Zhe's two-patch series, using that series' v2
>> as the integration point [2].
>>
>> Li Zhe (2):
>> mm/mm_init: factor out memmap_init_page_from_template()
>> mm/hugetlb: optimize bootmem hugepage tail vmemmap init
>>
>> Muchun Song (12):
>> mm/mm_init: verify zones for template-initialized pages
>> mm/mm_init: factor out common struct page initialization
>> mm/mm_init: simplify zone device page initialization
>> mm/mm_init: factor out frozen compound page initialization
>> mm/hugetlb: drop boot-time HVO handling for gigantic folios
>> mm/hugetlb: initialize all struct pages for bootmem hugepages
>> mm/hugetlb: use common compound page initialization helper
>> mm/mm_init: make __init_single_page() static
>> mm/mm_init: make memmap_init_page_from_template() static
>> mm/cma: centralize CMA pageblock initialization
>> mm/cma: localize init_cma_pageblock() to cma.c
>> mm/mm_init: move pageblock migratetype init to memmap helpers
>>
>> include/linux/mm.h | 8 --
>> mm/cma.c | 24 +++--
>> mm/hugetlb.c | 111 ++-----------------
>> mm/hugetlb_vmemmap.c | 17 +--
>> mm/mm_init.c | 247 +++++++++++++++++--------------------------
>> mm/mm_init.h | 13 +--
>> mm/sparse-vmemmap.c | 7 +-
>> 7 files changed, 129 insertions(+), 298 deletions(-)
>
> That's nice :)
>
> The series would be easier to review if Li Zhe's patches were integrated
> rather than stacked in. I hoped that the changes for template
> initialization would fit into the patches that rework other parts.
I have a much clearer idea of what you mean by integration now. I'll push
out a new version once the Zhe data testing is finished.
>
> The way it's done now several patches in the beginning of the series
> change code that the later patches remove or turn some of new functions
> into static.
>
> Another thing is that the numbers Li Zhe measured were for a different
> implementation, so they would be stale for the state after these
> changes.
>
> I have some nits and naming comments in a few patches, other than that
> the series LGTM.
Thanks for your review.
Muchun
>
> --
> Sincerely yours,
> Mike.
prev parent reply other threads:[~2026-11-17 3:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:34 Muchun Song
2026-11-13 3:34 ` [PATCH v2 01/14] mm/mm_init: factor out memmap_init_page_from_template() Muchun Song
2026-11-16 4:40 ` Lance Yang
2026-11-13 3:34 ` [PATCH v2 02/14] mm/hugetlb: optimize bootmem hugepage tail vmemmap init Muchun Song
2026-11-16 10:42 ` Mike Rapoport
2026-11-13 3:34 ` [PATCH v2 03/14] mm/mm_init: verify zones for template-initialized pages Muchun Song
2026-11-16 8:41 ` Lance Yang
2026-11-13 3:34 ` [PATCH v2 04/14] mm/mm_init: factor out common struct page initialization Muchun Song
2026-11-16 10:42 ` Mike Rapoport
2026-11-17 3:13 ` Muchun Song
2026-11-13 3:34 ` [PATCH v2 05/14] mm/mm_init: simplify zone device " Muchun Song
2026-11-13 3:34 ` [PATCH v2 06/14] mm/mm_init: factor out frozen compound " Muchun Song
2026-11-16 10:42 ` Mike Rapoport
2026-11-17 3:11 ` Muchun Song
2026-11-13 3:34 ` [PATCH v2 07/14] mm/hugetlb: drop boot-time HVO handling for gigantic folios Muchun Song
2026-11-13 3:34 ` [PATCH v2 08/14] mm/hugetlb: initialize all struct pages for bootmem hugepages Muchun Song
2026-11-13 3:34 ` [PATCH v2 09/14] mm/hugetlb: use common compound page initialization helper Muchun Song
2026-11-13 3:34 ` [PATCH v2 10/14] mm/mm_init: make __init_single_page() static Muchun Song
2026-11-13 3:34 ` [PATCH v2 11/14] mm/mm_init: make memmap_init_page_from_template() static Muchun Song
2026-11-13 3:34 ` [PATCH v2 12/14] mm/cma: centralize CMA pageblock initialization Muchun Song
2026-11-13 3:34 ` [PATCH v2 13/14] mm/cma: localize init_cma_pageblock() to cma.c Muchun Song
2026-11-13 3:34 ` [PATCH v2 14/14] mm/mm_init: move pageblock migratetype init to memmap helpers Muchun Song
2026-11-16 4:20 ` [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Lance Yang
2026-11-16 10:42 ` Mike Rapoport
2026-11-16 11:17 ` Li Zhe
2026-11-17 3:57 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A4F207DD-9535-42EC-B9A6-88578BFE369B@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=david@kernel.org \
--cc=jthoughton@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhe.67@bytedance.com \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®