From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801BA389118 for ; Wed, 13 May 2026 11:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778672655; cv=none; b=IkIx9TY/rw7mYD7kBAeTNJAfGBKZO5mfswVI2hQK6HUTv45NxtnWlF5VSme9qHpyRm/lXD2MaIz8MxovLpxkDxQxTKHOHbVxToP5l46XA2dAoqLbOHyyv5N//k7eDbYqUeTJxQL8An61sUoYISilk2OZ1RhD5wFtVsWGNWJa0PA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778672655; c=relaxed/simple; bh=1a+V7SN5Ad1tvDfgTgTwhX+lul4htUJKibU3Otb53LQ=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=BWOgkp+OlB6JVsAN2fAepjSUKx2/V5cg8d/OIPCtpmx0BgQd3/OJD6g71fkqbJ9RV0QzhIFhpHvc/7esxXKixJPan855K8YRsmhMW5DcxLvbwt31ou9yO2NyFhtlxWC/qesyau0jLCUqqTDfsSPZLvNjq6xvsxRNyIAF26ZthJY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gEq1hdHh; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gEq1hdHh" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-366330b6751so4430928a91.1 for ; Wed, 13 May 2026 04:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778672652; x=1779277452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=qYAcfX5TZQ1aO/tUlnMIN+1pF6qLETPLwxG8ZHIUVfI=; b=gEq1hdHhXaN9hfUHDRC7spe2P68YK/n731u3tq7uWrGdzINNnmUDOW8Oh9KoWScOJQ DN+ORe3jW3HsyQaZlizJ061yElkn9LWzIsSBZXdnsVWC//Z4qEac0uH3WC7WtQt/r6Lp LpJbgi/L7q30rhoCdMLKlMEArpOvB3gabBHhgdz7oLPiDlUXRwVYuIgNL96jLwq6F+s7 V0LzfBYxepKqOYbH7jtH0yybby9sEZnliRKesNpyzUdmDLqSxybjHEGu5z6TA4izw8ag KJjuiM5FQBkGf9fvN5lPrNRGAsfzfPNAVXIOiZxizw0YMfntq/c89OBKQfIN7XwvTy4U FTcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778672652; x=1779277452; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qYAcfX5TZQ1aO/tUlnMIN+1pF6qLETPLwxG8ZHIUVfI=; b=JEEhZAgbj8n793vrEUcJurR/RgmgUWLZ1k6pVlRT5wE7WfjiogNWtZv2udydR0DaRh 7D3JGF4sTqhEed6Ze0qV7UdbTekvBuM7wnbSxgcSFGpJRVvI19swvwIaQ1GVFtp4GHFr SV/Tq6CCRKU/h2YdAC8a/z07dDBCiaea28d3qYhtOvWvoR0tmGSowlN831tMwdc6NK6K o5hRxv4YiERp3Fphfpoxdzzi2o2sD9k/6WatLuWwthEUWm1J4QXq4JphyytpC6lZKpn0 t99oyPchMiE2LeHv1//wsD3eYWe0zg19HCQhRKoNhUc0MXeZDrO57Uc5MoHC4sNNDo/k d4qw== X-Forwarded-Encrypted: i=1; AFNElJ9pJdZfOBAp8AUAuQwM0BmkHh+SRAdqJkHD/t0eGqQ+eI+SJ21cnYEyywMsc5/rSBx/He3h+a4cmY3PPcA=@vger.kernel.org X-Gm-Message-State: AOJu0YxS3zQJnRdEbLIIHiBnWpUcooNy+yHpcWGF93OL00l/8pXYJUfC zvdio8BRidggyMzCPdurlBK6k2WM2grZ7gUwUmCii/xYtbm51OqOip6c X-Gm-Gg: Acq92OFQ5MrGay+cKuxcxHYu+KVWtOc/9XzOSVt1OvpP0TsDJAul5lS9qXpKuFPwdG4 3VhGdiMSI6uofQrpn9BxzdNuOFEKJR2NqybvqM+izB8DWEIucwyc+Sr1t1yKWkMthxeUxS3+Vfq cL6ZiSwpeupH2PTx2XTRSwwUmVwNbBjQl40JSEjd3TO9HP/PM5lIp/BACbQZaT2tM7ZNC0WJQog S9hSLDP/h8SNvDEwPvyi7XeIv9kF7y74PDUwnCSZ8W5ZzXP4KJyGkU0EmojUhtEWQ/wkwYt14NJ phFbXArt0Legm2RuiikmL93Ma+n19TCAUoBVmvoYXQtDqBLc/9tkKGRzN1qb7+HqTMUS+5sqn9U 4rTBw71RKaBaKQDiLyc6gkDiBTRYViyVKz4FMN95H/iNiHeU6ytUlSUEluzVw3fp8zlCZD0TjiV WoApd/vAzzZ4rZ+wAtrP0E6UqJWAZrHlx5HHQpvYP2YVjk1zw= X-Received: by 2002:a17:903:9ce:b0:2bd:56c:97ad with SMTP id d9443c01a7336-2bd2ec5abd3mr25711825ad.0.1778672651705; Wed, 13 May 2026 04:44:11 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ac0f:c362:ceaf:f4a4:19f1:7e92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d52f27sm204870005ad.36.2026.05.13.04.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 04:44:11 -0700 (PDT) Date: Wed, 13 May 2026 17:14:05 +0530 From: Sanjay Chitroda To: Michal Piekos , Jonathan Cameron , David Lechner , =?ISO-8859-1?Q?Nuno_S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maksim Kiselev CC: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] iio: adc: sun20i-gpadc: add A523 gpadc support User-Agent: Thunderbird for Android In-Reply-To: <20260513-sunxi-a523-gpadc-v2-2-d5efde151dac@mmpsystems.pl> References: <20260513-sunxi-a523-gpadc-v2-0-d5efde151dac@mmpsystems.pl> <20260513-sunxi-a523-gpadc-v2-2-d5efde151dac@mmpsystems.pl> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13 May 2026 10:29:43=E2=80=AFam IST, Michal Piekos wrote: >A523 differs from existing sun20i-gpadc-iio by having two clocks; bus >clock and module clock=2E > >Change driver to enable all clocks=2E > >Signed-off-by: Michal Piekos >--- > drivers/iio/adc/sun20i-gpadc-iio=2Ec | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/drivers/iio/adc/sun20i-gpadc-iio=2Ec b/drivers/iio/adc/sun20= i-gpadc-iio=2Ec >index 861c14da75ad=2E=2E3f1f07b3a385 100644 >--- a/drivers/iio/adc/sun20i-gpadc-iio=2Ec >+++ b/drivers/iio/adc/sun20i-gpadc-iio=2Ec >@@ -180,7 +180,7 @@ static int sun20i_gpadc_probe(struct platform_device = *pdev) > struct iio_dev *indio_dev; > struct sun20i_gpadc_iio *info; > struct reset_control *rst; >- struct clk *clk; >+ struct clk_bulk_data *clks; > int irq; > int ret; >=20 >@@ -205,9 +205,11 @@ static int sun20i_gpadc_probe(struct platform_device= *pdev) > if (IS_ERR(info->regs)) > return PTR_ERR(info->regs); >=20 >- clk =3D devm_clk_get_enabled(dev, NULL); >- if (IS_ERR(clk)) >- return dev_err_probe(dev, PTR_ERR(clk), "failed to enable bus clock\n"= ); >+ ret =3D devm_clk_bulk_get_all_enabled(dev, &clks); >+ if (ret <=3D 0) Thank you Michal for the change=2E Have you validated the changes ? It looks while success ret would be 0 and it would give return error=2E Thanks, Sanjay >+ return dev_err_probe( >+ dev, ret, >+ "failed to enable clocks or no clocks defined\n"); >=20 > rst =3D devm_reset_control_get_exclusive(dev, NULL); > if (IS_ERR(rst)) >@@ -243,6 +245,7 @@ static int sun20i_gpadc_probe(struct platform_device = *pdev) >=20 > static const struct of_device_id sun20i_gpadc_of_id[] =3D { > { =2Ecompatible =3D "allwinner,sun20i-d1-gpadc" }, >+ { =2Ecompatible =3D "allwinner,sun55i-a523-gpadc" }, > { } > }; > MODULE_DEVICE_TABLE(of, sun20i_gpadc_of_id); >