From: Benjamin Coddington <bcodding@redhat.com>
To: Hou Tao <houtao@huaweicloud.com>
Cc: linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
houtao1@huawei.com
Subject: Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker
Date: Mon, 08 Jan 2024 10:48:24 -0500 [thread overview]
Message-ID: <A7DF37C3-9C00-4C3C-BFD3-12BE0DE699B3@redhat.com> (raw)
In-Reply-To: <20240105105305.4052672-1-houtao@huaweicloud.com>
On 5 Jan 2024, at 5:53, Hou Tao wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> When invoking virtio_fs_enqueue_req() through kworker, both the
> allocation of the sg array and the bounce buffer still use GFP_ATOMIC.
> Considering the size of both the sg array and the bounce buffer may be
> greater than PAGE_SIZE, use GFP_NOFS instead of GFP_ATOMIC to lower the
> possibility of memory allocation failure.
Perhaps not appropriate for this case, but are you aware of
memalloc_nofs_save/restore? NFS has been converting over and cleaning out
our GFP_NOFS usage:
Documentation/core-api/gfp_mask-from-fs-io.rst
Ben
prev parent reply other threads:[~2024-01-08 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 10:53 Hou Tao
2024-01-05 20:17 ` Vivek Goyal
2024-01-05 20:21 ` Matthew Wilcox
2024-01-05 20:41 ` Vivek Goyal
2024-01-05 20:57 ` Matthew Wilcox
2024-01-05 21:27 ` Vivek Goyal
2024-01-06 6:26 ` Hou Tao
2024-01-06 2:48 ` Hou Tao
2024-01-08 15:48 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A7DF37C3-9C00-4C3C-BFD3-12BE0DE699B3@redhat.com \
--to=bcodding@redhat.com \
--cc=houtao1@huawei.com \
--cc=houtao@huaweicloud.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®