From: Kees Cook <kees@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Kees Cook <keescook@chromium.org>
Cc: azeemshaikh38@gmail.com, Adam Radford <aradford@gmail.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, jejb@linux.ibm.com,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
Date: Mon, 22 May 2023 18:21:02 -0700 [thread overview]
Message-ID: <A8157E92-E340-4031-8054-378728CC5BD4@kernel.org> (raw)
In-Reply-To: <yq18rdgm1mo.fsf@ca-mkp.ca.oracle.com>
On May 22, 2023 3:41:58 PM PDT, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:
>
>Kees,
>
>> On Wed, 17 May 2023 14:29:55 +0000, Azeem Shaikh wrote:
>>> strlcpy() reads the entire source buffer first.
>>> This read may exceed the destination size limit.
>>> This is both inefficient and can lead to linear read
>>> overflows if a source string is not NUL-terminated [1].
>>> In an effort to remove strlcpy() completely [2], replace
>>> strlcpy() here with strscpy().
>>> No return values were used, so direct replacement is safe.
>>>
>>> [...]
>>
>> Applied to for-next/hardening, thanks!
>>
>> [1/1] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
>> https://git.kernel.org/kees/c/fa36c95739ab
>
>Are you planning on sending these? That's fine with me, just need to
>know if I should close them in patchwork...
Yeah, I took a bunch that hadn't been picked up yet:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/hardening
Thanks!
--
Kees Cook
prev parent reply other threads:[~2023-05-23 1:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 14:29 Azeem Shaikh
2023-05-17 19:13 ` Kees Cook
2023-05-22 19:39 ` Kees Cook
2023-05-22 22:41 ` Martin K. Petersen
2023-05-23 1:21 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A8157E92-E340-4031-8054-378728CC5BD4@kernel.org \
--to=kees@kernel.org \
--cc=aradford@gmail.com \
--cc=azeemshaikh38@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®