From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6E181A6808 for ; Sun, 12 Apr 2026 16:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776009920; cv=none; b=rPK/0EvPcwMKK6HsOtpaVJngoOdae+2L4fLtGJzMhMnHm5XmtDlQRGpZ+JurFewIQCw8bUoBUjNMvSHGZPkMNSrx74+AaSHKR6vEICT6dJcJe1PZQm9QzHdqPKHL8vpEgaPHzuWU98cBt/KR1zy1qvSnCxFEboLf5j1+pFcAmUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776009920; c=relaxed/simple; bh=tBovWnNObEzNw2KsrwvW65q1Hxb+4dRW+dIhKIK0jGM=; h=From:Date:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=lWdD7OmwfQb5x/0kQa/LaCz5gLfT5uXIsn+ZZEXv9oPnmkT3N/hu7M+kxhh4dVNqNL3jIutJ6e7+a3ItTGnOvmfv71TMGsw/9eoCs0Ktf9obo3GklyFrFLVbs9oEZxbgdW2iGDff0OgmyKZS4p6KzoDOvHJyfF3y8jtkzwe0ivA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lWmwFpwX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lWmwFpwX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so13333955e9.2 for ; Sun, 12 Apr 2026 09:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776009916; x=1776614716; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to; bh=wC/3mbKh4Jia5xjgb7N3qVQgvwa11PmO5aeBln3pAXE=; b=lWmwFpwXM2v+rWIbgQ6CPpjX0j9Fnzc6KxstO1yj8YbSUlnFmzrL86btrWrSVO5NVQ GZy6diAd4gRAERP7WfQmqQjVEVbVBk3HX8XpA0JtX9l5JGPDsDVuzFcCk9tPEIvwbHGq VhKZOBOGV1gzG9Sx8YrPr0l3KymBDdSbxX8clygErXzd7ri0HHD0OR6BKKFhTiLTqTQN 6ZukhwVqQM3xV7OmpfK0j08MqPmMf59OqJKxBQFkH0iQCQTA8I5yk3otyfJmem0j+Nbh b0uIP6+neLfSRVl5ZOkVDuAMwMmqDC3jEd4GRZv4VFCQbSqCvfejs353qG+MM/gC3xZ/ wUrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776009916; x=1776614716; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wC/3mbKh4Jia5xjgb7N3qVQgvwa11PmO5aeBln3pAXE=; b=dY3xPsq4cgwlWAJWxG9UrnedE+wLeJSz/jiJo1UPWWzZ2foPzqzquNKb7Py9FGQnn8 lmT/YK23EbwW/afBNNycSaHLtiRUmV0dqYdmPwsXyzI8ylYqFln1pFi8Lud/tVyr5jgT ArqaSZG5HInyoki6F00kwwXeBnn4mKzNlbXEZ6kxQs7YNNrkAiw7waYSpvo460xQpIPZ SuhzTw1f8fE4iz+eSeUg58JUjdmESuLWsJgtvTwKmvvpOL1J37OAQxU7shehkqAz6o5V +BFLwdMhaaS7VLiexSGzl8f3joXSEINI9SZY3zHOfO3F0cikA/bnADnD+MwisWrgKhY3 B07Q== X-Forwarded-Encrypted: i=1; AJvYcCUDfDr/vPyZGjjyyuLTK8jWknNdFfz5LI+G9wCw2v1goX4FKcwLN4rOhyJAAQ89e03lYAL0E0n+XHAv1/I=@vger.kernel.org X-Gm-Message-State: AOJu0YyFVDthuoLdGf2UeQ5DgiVxwq6/GqW4u+MX5ttQIc7QIq5ooOu/ NelAwHuXptdIGa7GzP0lDRpGucSUUv2c5Sdz4H17qXX1HyutYIPzBCo= X-Gm-Gg: AeBDievCYJaA78JoR6VbrjlL/RNSLaUTsyoaTEr4DQ6x1xElz8LjathqAgNeNVsOScb GCRo49M9RPI6RqkOHULPV9C9nW+gy4G2iiErdBCIM7sERn2QKgFFVe3GA3VCfYj2ubjOqj7kkFR E+7Sfwt8ALoLgvRC1F1ELeRdfGqgTUTNL1bFtZMRQoyhpOa8v/ce0yi8E5Z+2EQRtE9HQnstgBE WWubOrpZjYgKbVckwU9dRw2egAfUWqPJtrIf2gjxJ1GLeNRAhBMJQiT1tTEU+5v5UbXGoBBJ62s YGfvWrLeQCjVQL8OezM0KCtQ58Z6dzimi0WUcio/g8pRJxq/fl5zZA+JgPb2B3wjWiSjS7CjBwX 9lMokwJmvWnIR7i/Ts1XVFyF3HEansWLoRxFxtPDsGG/Ys80xxWlAJvqjracbiZJImif4bG8pFH blX6eezIXcfP7sS/kLbt/3Xd3RYemWB3erEXRxEliLBjWvTGeb/s9OKHMqt5pZ+gjnsO7N+OldZ QrwnU2K0QjTTrSguXdzcUI= X-Received: by 2002:a05:600c:64c4:b0:485:30d4:6b9e with SMTP id 5b1f17b1804b1-488d686c04fmr125862875e9.21.1776009916032; Sun, 12 Apr 2026 09:05:16 -0700 (PDT) Received: from ehlo.thunderbird.net ([31.223.145.20]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d531f1f9sm280937675e9.1.2026.04.12.09.05.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Apr 2026 09:05:15 -0700 (PDT) From: Luka Gejak X-Google-Original-From: Luka Gejak Date: Sun, 12 Apr 2026 18:05:11 +0200 To: Josh Hesketh , Greg Kroah-Hartman CC: Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, luka.gejak@linux.dev Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_1/3=5D_staging=3A_rtl8723bs=3A_remo?= =?US-ASCII?Q?ve_commented_out_dead_code_in_sdio=5Fhalinit=2Ec?= User-Agent: Thunderbird for Android In-Reply-To: <20260412150633.12071-1-josh.hesketh@gmail.com> References: <20260412150633.12071-1-josh.hesketh@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM=2E Reviewed-by: Luka Gejak On April 12, 2026 5:06:31 PM GMT+02:00, Josh Hesketh wrote: >Remove commented out dead code that have been dead since the >driver was introduced to staging=2E Code can be recovered from >git history if needed=2E > >Signed-off-by: Josh Hesketh >--- >v2: > - Rebased on staging-next > - Split into separate patches per feedback > - Removed commented out dead code instead of fixing whitespace > drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec | 24 -------------------- > 1 file changed, 24 deletions(-) > >diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec b/drivers/sta= ging/rtl8723bs/hal/sdio_halinit=2Ec >index f2f73c65a636=2E=2E4d74b14c3cd4 100644 >--- a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec >+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec >@@ -46,8 +46,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) > u16 value16; > u32 value32; > u8 ret; >-/* u8 bMacPwrCtrlOn; */ >- >=20 > /* all of these MUST be configured before power on */ >=20 >@@ -69,10 +67,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) > value16 |=3D EnPDN; /* Enable HW power down and RF on */ > rtw_write16(padapter, REG_APS_FSMCO, value16); >=20 >- /* Enable CMD53 R/W Operation */ >-/* bMacPwrCtrlOn =3D true; */ >-/* rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */ >- > rtw_write8(padapter, REG_CR, 0x00); > /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ > value16 =3D rtw_read16(padapter, REG_CR); >@@ -359,7 +353,6 @@ static void _InitNetworkType(struct adapter *padapter= ) > value32 =3D rtw_read32(padapter, REG_CR); >=20 > /* TODO: use the other function to set network type */ >-/* value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AD_HOC); */ > value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AP); >=20 > rtw_write32(padapter, REG_CR, value32); >@@ -486,9 +479,6 @@ static void _initSdioAggregationSetting(struct adapte= r *padapter) > { > struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); >=20 >- /* Tx aggregation setting */ >-/* sdio_AggSettingTxUpdate(padapter); */ >- > /* Rx aggregation setting */ > HalRxAggr8723BSdio(padapter); >=20 >@@ -640,9 +630,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > return _SUCCESS; > } >=20 >- /* Disable Interrupt first=2E */ >-/* rtw_hal_disable_interrupt(padapter); */ >- > ret =3D _InitPowerOn_8723BS(padapter); > if (ret =3D=3D _FAIL) > return _FAIL; >@@ -661,8 +648,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) >=20 > rtl8723b_InitializeFirmwareVars(padapter); >=20 >-/* SIC_Init(padapter); */ >- > if (pwrctrlpriv->reg_rfoff) > pwrctrlpriv->rf_pwrstate =3D rf_off; >=20 >@@ -745,11 +730,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > rtw_hal_set_chnl_bw(padapter, padapter->registrypriv=2Echannel, > CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFS= ET_DONT_CARE); >=20 >- /* Record original value for template=2E This is arough data, we can o= nly use the data */ >- /* for power adjust=2E The value can not be adjustde according to diff= erent power!!! */ >-/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ >-/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrI= dx; */ >- > rtl8723b_InitAntenna_Selection(padapter); >=20 > /* */ >@@ -791,8 +771,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > /* ack for xmit mgmt frames=2E */ > rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_= TXQ_CTRL) | BIT(12)); >=20 >-/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_= HRPWM1) & 0x80; */ >- > { > pwrctrlpriv->rf_pwrstate =3D rf_on; >=20 >@@ -1080,8 +1058,6 @@ static void _ReadPROMContent(struct adapter *padapt= er) > pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; > pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; >=20 >-/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : E= EPROM_BOOT_EFUSE; */ >- > _ReadEfuseInfo8723BS(padapter); > } >=20