From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756648AbdJJV5y convert rfc822-to-8bit (ORCPT ); Tue, 10 Oct 2017 17:57:54 -0400 Received: from terminus.zytor.com ([65.50.211.136]:53297 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877AbdJJV5w (ORCPT ); Tue, 10 Oct 2017 17:57:52 -0400 Date: Tue, 10 Oct 2017 14:55:10 -0700 User-Agent: K-9 Mail for Android In-Reply-To: <20171010212244.1659577-1-terrelln@fb.com> References: <20171010212244.1659577-1-terrelln@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH 0/2] Add support for ZSTD-compressed kernel To: Nick Terrell CC: Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, kernel-team@fb.com, Chris Mason , Yann Collet , Rene Rebe From: hpa@zytor.com Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On October 10, 2017 2:22:42 PM PDT, Nick Terrell wrote: >Hi, > >This patch set adds support for a ZSTD-compressed kernel and ramdisk >images in the kernel boot process. It only integrates the support with >x86, though the first patch is generic to all architectures. > >Zstandard requires slightly more memory during the kernel decompression >on x86 (192 KB vs 64 KB), and the memory usage is independent of the >window size. > >Zstandard requires memory proprortional to the window size used during >compression for decompressing the ramdisk image, since streaming mode >is >used. Newer versions of zstd (1.3.2+) list the window size of a file >with `zstd -lv '. The absolute maximum amount of memory required >is just over 8 MB. > >Thanks, >Nick Terrell > >Nick Terrell (2): > lib: Add support for ZSTD-compressed kernel > x86: Add support for ZSTD-compressed kernel > > Documentation/x86/boot.txt | 6 +- > arch/x86/Kconfig | 1 + > arch/x86/boot/compressed/Makefile | 5 +- > arch/x86/boot/compressed/misc.c | 4 + > arch/x86/boot/header.S | 8 +- > arch/x86/include/asm/boot.h | 6 +- > include/linux/decompress/unzstd.h | 26 +++ > init/Kconfig | 14 +- > lib/Kconfig | 4 + > lib/Makefile | 1 + > lib/decompress.c | 5 + >lib/decompress_unzstd.c | 341 >++++++++++++++++++++++++++++++++++++++ > lib/xxhash.c | 21 ++- > lib/zstd/decompress.c | 2 + > lib/zstd/fse_decompress.c | 9 +- > scripts/Makefile.lib | 15 ++ > usr/Kconfig | 22 +++ > 17 files changed, 465 insertions(+), 25 deletions(-) > create mode 100644 include/linux/decompress/unzstd.h > create mode 100644 lib/decompress_unzstd.c And, pray tell, what are the actual results? What is the trade-off of kernel size versus decompression performance versus the other algorithms that we already support? Adding algorithms for their own sake is a bad thing not a good thing. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.