mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rustad <mrustad@mac.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg KH <gregkh@suse.de>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] PCI: restore 2 missing pci ids
Date: Wed, 1 Feb 2006 23:11:36 -0600	[thread overview]
Message-ID: <A9543B03-333E-470F-AD18-0313192ADB23@mac.com> (raw)
In-Reply-To: <43E0F73B.6040507@pobox.com>

Jeff,

On Feb 1, 2006, at 12:00 PM, Jeff Garzik wrote:

> Linux Kernel Mailing List wrote:
>> tree e425ac74afc0b89f3a513290a2dd5e503d974906
>> parent 654143ee3a73b2793350b039a135d9cd3101147b
>> author Mark Rustad <MRustad@mac.com> Fri, 06 Jan 2006 14:47:29 -0800
>> committer Greg Kroah-Hartman <gregkh@suse.de> Wed, 01 Feb 2006  
>> 10:00:11 -0800
>> [PATCH] PCI: restore 2 missing pci ids
>> Somewhere between 2.6.14 and 2.6.15-rc3, some PCI ids were apparently
>> removed.  The ecc.c module, which is not a part of the kernel.org  
>> tree, but
>> included in some distributions, fails to compile.
>> Signed-off-by: Mark Rustad <mrustad@mac.com>
>> Signed-off-by: Andrew Morton <akpm@osdl.org>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>>  include/linux/pci_ids.h |    2 ++
>>  1 files changed, 2 insertions(+)
>
> Why was this applied?  We could apply these patches all day, and  
> get nothing else done.  If it's not in the kernel tree, we  
> shouldn't be worrying about it.  Let the distros patch it in.

Well, I offered the patch because I found that I suddenly needed it.  
I did not know why the ids had been removed, but it looks to me like  
edac is coming right along and will need the ids itself, so I sent  
the patch off.

Frankly, I was surprised that the patch was so quickly accepted. I  
perceive some difference of opinion on how PCI ids should be handled.  
Is there a consensus on a better way to handle ids? Why were the ids  
removed in the first place? THAT was worse than wasted effort.

-- 
Mark Rustad, MRustad@mac.com


  reply	other threads:[~2006-02-02  5:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200602010609.k1169QDX017012@hera.kernel.org>
2006-02-01 18:00 ` Jeff Garzik
2006-02-02  5:11   ` Mark Rustad [this message]
2006-02-02  5:19     ` Lee Revell
2006-02-02  7:01       ` Kyle Moffett
2006-02-02  7:28         ` Jeff Garzik
2006-02-02 15:24           ` Mark Rustad
2006-01-20 19:04 [PATCH] PCI Hotplug: shpchp: AMD POGO errata fix Greg KH
2006-01-20 19:04 ` [PATCH] PCI: restore 2 missing pci ids Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A9543B03-333E-470F-AD18-0313192ADB23@mac.com \
    --to=mrustad@mac.com \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®