mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	BlueZ development <linux-bluetooth@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Pre-initialize variables in read_local_oob_ext_data_complete()
Date: Thu, 16 Apr 2015 13:34:54 -0700	[thread overview]
Message-ID: <A962A040-4EB5-4AE6-A790-A8767185172B@holtmann.org> (raw)
In-Reply-To: <1429212265-26750-1-git-send-email-geert@linux-m68k.org>

Hi Geert,

> net/bluetooth/mgmt.c: In function ‘read_local_oob_ext_data_complete’:
> net/bluetooth/mgmt.c:6474: warning: ‘r256’ may be used uninitialized in this function
> net/bluetooth/mgmt.c:6474: warning: ‘h256’ may be used uninitialized in this function
> net/bluetooth/mgmt.c:6474: warning: ‘r192’ may be used uninitialized in this function
> net/bluetooth/mgmt.c:6474: warning: ‘h192’ may be used uninitialized in this function
> 
> While these are false positives, the code can be shortened by
> pre-initializing the hash table pointers and eir_len. This has the side
> effect of killing the compiler warnings.

can you be a bit specific on which compiler version is this. I fixed one occurrence that seemed valid. However in this case the compiler seems to be just plain stupid. On a gcc 4.9, I am not seeing these for example.

Regards

Marcel


  reply	other threads:[~2015-04-16 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 19:24 Geert Uytterhoeven
2015-04-16 20:34 ` Marcel Holtmann [this message]
2015-04-17 20:03   ` Geert Uytterhoeven
2015-04-17 20:38     ` Marcel Holtmann
2015-04-20  8:47       ` Geert Uytterhoeven
2015-05-13 21:11         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A962A040-4EB5-4AE6-A790-A8767185172B@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=geert@linux-m68k.org \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®