From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050AbbKQA7f (ORCPT ); Mon, 16 Nov 2015 19:59:35 -0500 Received: from mga02.intel.com ([134.134.136.20]:19641 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbbKQA7d convert rfc822-to-8bit (ORCPT ); Mon, 16 Nov 2015 19:59:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,305,1444719600"; d="scan'208";a="687085337" From: "Zhang, Yang Z" To: Paolo Bonzini , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" CC: Takuya Yoshikawa Subject: RE: [PATCH] KVM: x86: always set accessed bit in shadow PTEs Thread-Topic: [PATCH] KVM: x86: always set accessed bit in shadow PTEs Thread-Index: AQHRHgI/JwAanx2JDUSriqmqPK39VZ6fakPg Date: Tue, 17 Nov 2015 00:59:30 +0000 Message-ID: References: <1447412302-3504-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1447412302-3504-1-git-send-email-pbonzini@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini wrote on 2015-11-13: > Commit 7a1638ce4220 ("nEPT: Redefine EPT-specific link_shadow_page()", > 2013-08-05) says: > > Since nEPT doesn't support A/D bit, we should not set those bit > when building the shadow page table. > but this is not necessary. Even though nEPT doesn't support A/D > bits, and hence the vmcs12 EPT pointer will never enable them, > we always use them for shadow page tables if available (see > construct_eptp in vmx.c). So we can set the A/D bits freely > in the shadow page table. > > This patch hence basically reverts commit 7a1638ce4220. > > Cc: Yang Zhang > Cc: Takuya Yoshikawa > Signed-off-by: Paolo Bonzini Looks good to me. Best regards, Yang