From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Albert Cranford <ac9410@bellsouth.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.5.25 I2C driver id and Config updates boundar
Date: Thu, 11 Jul 2002 13:23:08 +0200 [thread overview]
Message-ID: <A966E820E25@vcnet.vc.cvut.cz> (raw)
On 11 Jul 02 at 1:26, Albert Cranford wrote:
> Hello Linus,
> Could you please apply these 3 patches toward 2.5.26.
> They include Config.in updates, additions in i2c-id.h
> for "Video for Linux" and a compatibility fix for
> i2c-algo-bit.c
Hi,
is timeout field in i2c_algo_bit_data supposed to be in jiffies
(like it is currently used) or in 10ms units? If it is supposed
to be in jiffies (other algos do not care about timeout field),
there is dozen of places (all callers of i2c_bit_add_bus) which
get it wrong.
Next suspicious thing is that 'timeout' field from i2c_adapter
structure is not used at all - only i2c_control is willing to
set it, but nobody reads this field. Should not i2c_bit_add_bus
copy its timeout into this field, and then use adap->timeout instead
of bitadap->timeout in its sclhi() procedure?
Thanks,
Petr Vandrovec
vandrove@vc.cvut.cz
reply other threads:[~2002-07-11 11:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A966E820E25@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=ac9410@bellsouth.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®