From: Kees Cook <kees@kernel.org>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Amit Dhingra" <mechanicalamit@gmail.com>
Cc: "Timur Kristóf" <timur.kristof@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Leo Li" <sunpeng.li@amd.com>, "David Airlie" <airlied@gmail.com>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: linux-next-20251029 - build error in amdgpu
Date: Thu, 06 Nov 2025 06:02:23 -0800 [thread overview]
Message-ID: <A9C2FED1-EFBF-48AD-A3C8-41DDD16F8AA1@kernel.org> (raw)
In-Reply-To: <105884.1762399131@turing-police>
On November 5, 2025 7:18:51 PM PST, "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
>On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said:
>
>> I have the same problem.
>> ...
>
>> Setting RANDSTRUCT_NONE=y seems to stop the error.
>>
>> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/
>
>Wow. I wouldn't have guessed that RANDSTRUCT would be the cause...
>However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly.
>
><insert Twilight Zone theme music here>
>
>Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an
>idea what's going on.
I'm surprised the stable team didn't find the associated fix in your linked thread. It had the right Fixes tag:
https://lore.kernel.org/all/20250502224156.work.617-kees@kernel.org/
Regardless, just remove the "0" from the dce110_an_str_enc_funcs initializer; that's an older code pattern that isn't needed any more.
Randstruct requires designated initializers, though I thought the macro turned that on universally, so the fact that the error is only present with randstruct seems like a separate bug.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2025-11-06 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 17:20 Valdis Klētnieks
2025-10-30 18:05 ` Timur Kristóf
2025-11-02 0:59 ` Valdis Klētnieks
[not found] ` <CAFF-SiU3XL5pZAzsB=eXi7e1LKzx5XwiNOyfGpPXOnnc6uo2cw@mail.gmail.com>
2025-11-06 2:34 ` Amit Dhingra
2025-11-06 2:40 ` Timur Kristóf
2025-11-06 3:24 ` Amit Dhingra
2025-11-06 3:29 ` Timur Kristóf
2025-11-06 3:32 ` Amit Dhingra
2025-11-06 3:31 ` Valdis Klētnieks
2025-11-06 3:18 ` Valdis Klētnieks
2025-11-06 14:02 ` Kees Cook [this message]
2025-11-06 23:49 ` Bill Wendling
2025-11-08 15:10 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A9C2FED1-EFBF-48AD-A3C8-41DDD16F8AA1@kernel.org \
--to=kees@kernel.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mechanicalamit@gmail.com \
--cc=sunpeng.li@amd.com \
--cc=timur.kristof@gmail.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®