From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Colin King <colin.king@canonical.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: remove redundant initialization of variable ret
Date: Fri, 14 May 2021 04:43:15 +0000 [thread overview]
Message-ID: <AA283AE0-3520-4FC2-86E9-7471CC3B9635@wdc.com> (raw)
In-Reply-To: <20210513115952.58482-1-colin.king@canonical.com>
> On May 13, 2021, at 5:08 AM, Colin King <colin.king@canonical.com> wrote:
>
> - int ret = -EINVAL;
> + int ret;
> bool changed;
It'd be nice to move ret declaration after book changed.
next prev parent reply other threads:[~2021-05-14 4:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 11:59 Colin King
2021-05-14 4:43 ` Chaitanya Kulkarni [this message]
2021-05-19 7:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AA283AE0-3520-4FC2-86E9-7471CC3B9635@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=colin.king@canonical.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®