From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49B6C43331 for ; Sat, 28 Mar 2020 06:44:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C027020748 for ; Sat, 28 Mar 2020 06:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbgC1GoW convert rfc822-to-8bit (ORCPT ); Sat, 28 Mar 2020 02:44:22 -0400 Received: from mga04.intel.com ([192.55.52.120]:10518 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgC1GoW (ORCPT ); Sat, 28 Mar 2020 02:44:22 -0400 IronPort-SDR: lZpsa+sZ23JnQCZRSf5MVGpf1FBYM8FAvoYn81mbP5mtIHlrBr8Qgiwuaqckx3Ao80pZNXWjrI YSjSNKKekv7A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 23:44:21 -0700 IronPort-SDR: Luifc5ZLeKo9Za6t6vSeXRzzwDQeGumRNs/ozrB0q0wUnxydn/xYHDUtIQx1pM9/TXm70s0CDl NhrjHPnJEXiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,315,1580803200"; d="scan'208";a="236850536" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 27 Mar 2020 23:44:20 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 23:44:20 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 23:44:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.213]) with mapi id 14.03.0439.000; Sat, 28 Mar 2020 14:44:16 +0800 From: "Tian, Kevin" To: Jacob Pan CC: Joerg Roedel , Alex Williamson , Lu Baolu , "iommu@lists.linux-foundation.org" , LKML , David Woodhouse , Jean-Philippe Brucker , "Liu, Yi L" , "Raj, Ashok" , Christoph Hellwig , Jonathan Cameron , Eric Auger Subject: RE: [PATCH 09/10] iommu/ioasid: Support ioasid_set quota adjustment Thread-Topic: [PATCH 09/10] iommu/ioasid: Support ioasid_set quota adjustment Thread-Index: AQHWAs3NK42wQfu7/kyYiimhS040MqhcOJaQgABbOoCAAP8EAA== Date: Sat, 28 Mar 2020 06:44:15 +0000 Message-ID: References: <1585158931-1825-1-git-send-email-jacob.jun.pan@linux.intel.com> <1585158931-1825-10-git-send-email-jacob.jun.pan@linux.intel.com> <20200327163057.75a0e154@jacob-builder> In-Reply-To: <20200327163057.75a0e154@jacob-builder> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Jacob Pan > Sent: Saturday, March 28, 2020 7:31 AM > > On Fri, 27 Mar 2020 10:09:04 +0000 > "Tian, Kevin" wrote: > > > > From: Jacob Pan > > > Sent: Thursday, March 26, 2020 1:56 AM > > > > > > IOASID set is allocated with an initial quota, at runtime there may > > > be needs to balance IOASID resources among different VMs/sets. > > > > > > > I may overlook previous patches but I didn't see any place setting the > > initial quota... > > > Initial quota is in place when the ioasid_set is allocated. > > > > This patch adds a new API to adjust per set quota. > > > > since this is purely an internal kernel API, implies that the > > publisher (e.g. VFIO) is responsible for exposing its own uAPI to set > > the quota? > > > yes, VFIO will do the adjustment. I think Alex suggested module > parameters. ok, I remember that. > > > > > > > Signed-off-by: Jacob Pan > > > --- > > > drivers/iommu/ioasid.c | 44 > > > ++++++++++++++++++++++++++++++++++++++++++++ > > > include/linux/ioasid.h | 6 ++++++ > > > 2 files changed, 50 insertions(+) > > > > > > diff --git a/drivers/iommu/ioasid.c b/drivers/iommu/ioasid.c > > > index 27dce2cb5af2..5ac28862a1db 100644 > > > --- a/drivers/iommu/ioasid.c > > > +++ b/drivers/iommu/ioasid.c > > > @@ -578,6 +578,50 @@ void ioasid_free_set(int sid, bool destroy_set) > > > } > > > EXPORT_SYMBOL_GPL(ioasid_free_set); > > > > > > +/** > > > + * ioasid_adjust_set - Adjust the quota of an IOASID set > > > + * @quota: Quota allowed in this set > > > + * @sid: IOASID set ID to be assigned > > > + * > > > + * Return 0 on success. If the new quota is smaller than the > > > number of > > > + * IOASIDs already allocated, -EINVAL will be returned. No change > > > will be > > > + * made to the existing quota. > > > + */ > > > +int ioasid_adjust_set(int sid, int quota) > > > +{ > > > + struct ioasid_set_data *sdata; > > > + int ret = 0; > > > + > > > + mutex_lock(&ioasid_allocator_lock); > > > + sdata = xa_load(&ioasid_sets, sid); > > > + if (!sdata || sdata->nr_ioasids > quota) { > > > + pr_err("Failed to adjust IOASID set %d quota %d\n", > > > + sid, quota); > > > + ret = -EINVAL; > > > + goto done_unlock; > > > + } > > > + > > > + if (quota >= ioasid_capacity_avail) { > > > + ret = -ENOSPC; > > > + goto done_unlock; > > > + } > > > + > > > + /* Return the delta back to system pool */ > > > + ioasid_capacity_avail += sdata->size - quota; > > > + > > > + /* > > > + * May have a policy to prevent giving all available > > > IOASIDs > > > + * to one set. But we don't enforce here, it should be in > > > the > > > + * upper layers. > > > + */ > > > + sdata->size = quota; > > > + > > > +done_unlock: > > > + mutex_unlock(&ioasid_allocator_lock); > > > + > > > + return ret; > > > +} > > > +EXPORT_SYMBOL_GPL(ioasid_adjust_set); > > > > > > /** > > > * ioasid_find - Find IOASID data > > > diff --git a/include/linux/ioasid.h b/include/linux/ioasid.h > > > index 32d032913828..6e7de6fb91bf 100644 > > > --- a/include/linux/ioasid.h > > > +++ b/include/linux/ioasid.h > > > @@ -73,6 +73,7 @@ int ioasid_alloc_set(struct ioasid_set *token, > > > ioasid_t quota, int *sid); > > > void ioasid_free_set(int sid, bool destroy_set); > > > int ioasid_find_sid(ioasid_t ioasid); > > > int ioasid_notify(ioasid_t id, enum ioasid_notify_val cmd); > > > +int ioasid_adjust_set(int sid, int quota); > > > > > > #else /* !CONFIG_IOASID */ > > > static inline ioasid_t ioasid_alloc(int sid, ioasid_t min, > > > @@ -136,5 +137,10 @@ static inline int ioasid_alloc_system_set(int > > > quota) return -ENOTSUPP; > > > } > > > > > > +static inline int ioasid_adjust_set(int sid, int quota) > > > +{ > > > + return -ENOTSUPP; > > > +} > > > + > > > #endif /* CONFIG_IOASID */ > > > #endif /* __LINUX_IOASID_H */ > > > -- > > > 2.7.4 > > > > [Jacob Pan]