From: Rahul Ruikar <rahul.ruikar@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: dummy_hcd: Fix error path
Date: Sat, 2 Oct 2010 20:16:51 +0530 [thread overview]
Message-ID: <AANLkTi==MpP6FpvqWtmHwDM7CCRbTAz-TMyLS_Z_thGj@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1010021018250.15874-100000@netrider.rowland.org>
On 2 October 2010 20:01, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Sat, 2 Oct 2010, Rahul Ruikar wrote:
>
>> In function dummy_udc_probe()
>> call put_device() when device_register() fails.
>>
>> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
>> ---
>> drivers/usb/gadget/dummy_hcd.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
>> index dc65462..2548091 100644
>> --- a/drivers/usb/gadget/dummy_hcd.c
>> +++ b/drivers/usb/gadget/dummy_hcd.c
>> @@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
>> dum->gadget.dev.parent = &pdev->dev;
>> dum->gadget.dev.release = dummy_gadget_release;
>> rc = device_register (&dum->gadget.dev);
>> - if (rc < 0)
>> + if (rc < 0) {
>> + put_device(&dum->gadget.dev);
>> return rc;
>> + }
>>
>> usb_get_hcd (dummy_to_hcd (dum));
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Similar changes are needed in net2280.c, file_storage.c and
> f_mass_storage.c, probably also in goku_udc.c and langwell_udc.c.
> Would you like to make them?
>
yes Alan, I am aware of changes needed in these files. actually there
are many other changes needed for these files ( apart from
device_register() failure.. ) I am working on these files. also this
current patch need some updates.
Thanks,
Rahul
> Alan Stern
>
>
prev parent reply other threads:[~2010-10-02 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 7:23 Rahul Ruikar
2010-10-02 14:31 ` Alan Stern
2010-10-02 14:38 ` Alan Stern
2010-10-02 14:46 ` Rahul Ruikar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi==MpP6FpvqWtmHwDM7CCRbTAz-TMyLS_Z_thGj@mail.gmail.com' \
--to=rahul.ruikar@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®