From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637Ab1AOLYB (ORCPT ); Sat, 15 Jan 2011 06:24:01 -0500 Received: from mail-qy0-f181.google.com ([209.85.216.181]:52581 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275Ab1AOLX7 convert rfc822-to-8bit (ORCPT ); Sat, 15 Jan 2011 06:23:59 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; b=VVTYGC1dwH/8oIjor+Y6cTjl1cP3LImb1Z2II07dDgW9SneTsp6kFvkTbUXplsdq8j TbLwpan6zGp4XENvjchOR1aymklIZNN3SBsJxDco6F/M1YbQMNQl/JuMPQnWfhSNEHCp vok34hbSiCAqICMg5eYVyZ115zbDv8ujf7aRw= MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <20110115075723.GJ19804@ZenIV.linux.org.uk> <20110115090702.GK19804@ZenIV.linux.org.uk> <20110115110848.GL19804@ZenIV.linux.org.uk> Date: Sat, 15 Jan 2011 12:23:57 +0100 Message-ID: Subject: Re: linux-next: Tree for January 15 (Call Trace in fs/dcache.c + autofs4) From: Sedat Dilek To: Al Viro Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 15, 2011 at 12:16 PM, Sedat Dilek wrote: > On Sat, Jan 15, 2011 at 12:08 PM, Al Viro wrote: >> On Sat, Jan 15, 2011 at 12:00:54PM +0100, Sedat Dilek wrote: >> >>> > Argh... ??In __do_follow_link() replace >>> > >>> > ?? ?? ?? ??if (link->mnt != nd->path.mnt) >>> > with >>> > ?? ?? ?? ??if (link->mnt == nd->path.mnt) >>> > >>> > Mismerge yesterday ;-/ ??I've pushed fix for that in for-next, will fold >>> > shortly. ??As for autofs4 breakage, I've a preliminary fix, testing it >>> > now. >>> > >>> >>> Hey, cool and thanks. >>> >>> Not sure if you catched them all, I have noticed on my latest >>> ("buggy") linux-next kernel these Call Traces when doing an >>> update-grub. >> >> That might be vfsmount being dropped when it shouldn't or dentry leaked. >> And seeing that it's umount(8), I would suspect the latter... >> >> Anyway, with the latest from dhowells we probably should have >> d_set_d_op() mess on autofs4 under control (in #for-next).  Whether >> it's enough to actually fix the sucker is a separate question, of >> course - there might very well be more crap. >> >> I've instrumented mntput() et.al. here; hopefully that'll make catching >> the remaining turds easier.  As for dcache leaks... ouch.  Could you >> try to reproduce that one on the mainline kernel?  At least that'd >> isolate things a bit. >> > > Which version do you mean by "mainline"? 2.6.37-git12? > And with "[mismerge][foldme] breakage in __do_follow_link()" patch [1]? > I have to look by pulling-in(to) Linus-tree (linux-next) which patches > are not merged already. > > - Sedat - > > [1] http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=2f3740b3a80bc19498b3ec9b86a25d5941545436 > OK, I will try with these two patches and report later. - Sedat - P.S.: sd@tbox:~/src/linux-2.6/linux-2.6.37/debian/patches$ ls -l vfs-2.6-for-next/ insgesamt 28 -rw-r--r-- 1 sd sd 737 15. Jan 12:21 0001-mismerge-foldme-breakage-in-__do_follow_link.patch -rw-r--r-- 1 sd sd 4446 15. Jan 12:21 0002-autofs4-Merge-the-remaining-dentry-ops-tables.patch -rw-r--r-- 1 sd sd 201 15. Jan 12:21 diffstat -rw-r--r-- 1 sd sd 232 15. Jan 12:21 Shortlog -rw-r--r-- 1 sd sd 4417 15. Jan 12:21 vfs-2.6-for-next.patch