From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755295Ab0FAITq (ORCPT ); Tue, 1 Jun 2010 04:19:46 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:33001 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754096Ab0FAITn convert rfc822-to-8bit (ORCPT ); Tue, 1 Jun 2010 04:19:43 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=NZOpeDPb8Ejb86W2LyFdmY4AlhnBCDmUS0g3zom51alIJawLKItjsJV9+Mn0WMhYIO nl9SDh5D8yKWfM6v0ZNHpHJBWEo+lZpRxq7dE8hE8dohYZ6iH5yIDyMxdJ4C8dMct1KN UG0PgJ6gXMRFanffwVJZFwLS1xLEIqkcMwgOA= MIME-Version: 1.0 In-Reply-To: <20100531135227.GC19784@uudg.org> References: <20100528152842.GH11364@uudg.org> <20100528154549.GC12035@barrios-desktop> <20100528164826.GJ11364@uudg.org> <20100531092133.73705339.kamezawa.hiroyu@jp.fujitsu.com> <20100531140443.b36a4f02.kamezawa.hiroyu@jp.fujitsu.com> <20100531145415.5e53f837.kamezawa.hiroyu@jp.fujitsu.com> <20100531155102.9a122772.kamezawa.hiroyu@jp.fujitsu.com> <20100531135227.GC19784@uudg.org> Date: Tue, 1 Jun 2010 17:19:42 +0900 Message-ID: Subject: Re: [RFC] oom-kill: give the dying task a higher priority From: Minchan Kim To: "Luis Claudio R. Goncalves" , Peter Zijlstra Cc: KAMEZAWA Hiroyuki , KOSAKI Motohiro , balbir@linux.vnet.ibm.com, Oleg Nesterov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Gleixner , David Rientjes , Mel Gorman , williams@redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 31, 2010 at 10:52 PM, Luis Claudio R. Goncalves wrote: > On Mon, May 31, 2010 at 03:51:02PM +0900, KAMEZAWA Hiroyuki wrote: > | On Mon, 31 May 2010 15:09:41 +0900 > | Minchan Kim wrote: > | > On Mon, May 31, 2010 at 2:54 PM, KAMEZAWA Hiroyuki > | > wrote: > ... > | > >> > IIUC, the purpose of rising priority is to accerate dying thread to exit() > | > >> > for freeing memory AFAP. But to free memory, exit, all threads which share > | > >> > mm_struct should exit, too. I'm sorry if I miss something. > | > >> > | > >> How do we kill only some thread and what's the benefit of it? > | > >> I think when if some thread receives  KILL signal, the process include > | > >> the thread will be killed. > | > >> > | > > yes, so, if you want a _process_ die quickly, you have to acceralte the whole > | > > threads on a process. Acceralating a thread in a process is not big help. > | > > | > Yes. > | > > | > I see the code. > | > oom_kill_process is called by > | > > | > 1. mem_cgroup_out_of_memory > | > 2. __out_of_memory > | > 3. out_of_memory > | > > | > > | > (1,2) calls select_bad_process which select victim task in processes > | > by do_each_process. > | > But 3 isn't In case of  CONSTRAINT_MEMORY_POLICY, it kills current. > | > In only the case, couldn't we pass task of process, not one of thread? > | > > | > | Hmm, my point is that priority-acceralation is against a thread, not against a process. > | So, most of threads in memory-eater will not gain high priority even with this patch > | and works slowly. > > This is a good point... > > | I have no objections to this patch. I just want to confirm the purpose. If this patch > | is for accelating exiting process by SIGKILL, it seems not enough. > > I understand (from the comments in the code) the badness calculation gives more > points to the siblings in a thread that have their own mm. I wonder if what you > are describing is not a corner case. > > Again, your idea sounds like an interesting refinement to the patch. I am > just not sure this change should implemented now or in a second round of > changes. First of all, I think your patch is first. That's because I am not sure this logic is effective. /* * We give our sacrificial lamb high priority and access to * all the memory it needs. That way it should be able to * exit() and clear out its resources quickly... */ p->rt.time_slice = HZ; Peter changed it in fa717060f1ab. Now if we change rt.time_slice as HZ, it means the task have high priority? I am not a scheduler expert. but as I looked through scheduler code, rt.time_slice is only related to RT scheduler. so if we uses CFS, it doesn't make task high priority. Perter, Right? If it is right, I think Luis patch will fix it. Secondly, as Kame pointed out, we have to raise whole thread's priority to kill victim process for reclaiming pages. But I think it has deadlock problem. If we raise whole threads's priority and some thread has dependency of other thread which is blocked, it makes system deadlock. So I think it's not easy part. If this part is really big problem, we should consider it more carefully. > > | If an explanation as "acceralating all thread's priority in a process seems overkill" > | is given in changelog or comment, it's ok to me. > > If my understanding of badness() is right, I wouldn't be ashamed of saying > that it seems to be _a bit_ overkill. But I may be wrong in my > interpretation. > > While re-reading the code I noticed that in select_bad_process() we can > eventually bump on an already dying task, case in which we just wait for > the task to die and avoid killing other tasks. Maybe we could boost the > priority of the dying task here too. Yes. It is good where we boost priority of task, I think. > > Luis > -- > [ Luis Claudio R. Goncalves                    Bass - Gospel - RT ] > [ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9  2696 7203 D980 A448 C8F8 ] > > -- Kind regards, Minchan Kim