Re: [PATCH] signal: annotate siglock acquisition

[Namhyung Kim <namhyung@gmail.com>]

On Sat, Sep 25, 2010 at 18:42, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le samedi 25 septembre 2010 à 18:21 +0900, Namhyung Kim a écrit :
>> @@ -1403,7 +1404,9 @@ int send_sigqueue(struct sigqueue *q, struct task_struct *t, int group)
>>       BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
>>
>>       ret = -1;
>> -     if (!likely(lock_task_sighand(t, &flags)))
>> +     if (likely(lock_task_sighand(t, &flags)))
>> +             __acquire(&t->sighand->siglock);
>> +     else
>>               goto ret;
>>
>>       ret = 1; /* the signal is ignored */
>
> making sparse happy is good, but changing a likely clause is not,
> unless you meant it ;)
>
> maybe -->
>
>        if (!likely(lock_task_sighand(t, &flags)))
>                goto ret;
>        else
>                __acquire(&t->sighand->siglock);
>
>
>
>

What's the difference? I didn't change the semantics of likely clause
but simply exchange the order of then-else part because IMHO a
negative expression make it hard to understand, generally.
I've checked compiled binaries for both cases on x86 and they
produced exactly same code.

Thanks.


-- 
Regards,
Namhyung Kim