From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757277Ab0EZKR0 (ORCPT ); Wed, 26 May 2010 06:17:26 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:52101 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757138Ab0EZKRY convert rfc822-to-8bit (ORCPT ); Wed, 26 May 2010 06:17:24 -0400 MIME-Version: 1.0 In-Reply-To: <1274868384.5882.5169.camel@twins> References: <201005252344.37639.rjw@sisk.pl> <1274863342.5882.4850.camel@twins> <20100526112303.3fef15a4@schatten.dmk.lab> <1274866402.5882.5051.camel@twins> <1274868384.5882.5169.camel@twins> Date: Wed, 26 May 2010 03:17:23 -0700 Message-ID: Subject: Re: [PATCH 1/8] PM: Opportunistic suspend support. From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Peter Zijlstra Cc: Florian Mickler , "Rafael J. Wysocki" , Alan Stern , Dmitry Torokhov , Linux-pm mailing list , Kernel development list , Len Brown , Pavel Machek , Randy Dunlap , Andrew Morton , Andi Kleen , Cornelia Huck , Tejun Heo , Jesse Barnes , Nigel Cunningham , Ming Lei , Wu Fengguang , Maxim Levitsky , linux-doc@vger.kernel.org, Matthew Garrett , Greg KH , tytso@mit.edu, James Bottomley Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2010/5/26 Peter Zijlstra : > On Wed, 2010-05-26 at 02:54 -0700, Arve Hjønnevåg wrote: >> >> I'm not sure what you are proposing that we use instead. Both >> user-space and kernel code needs to block suspend. If we don't have >> suspend blockers in the kernel then user-space needs to poll when a >> driver blocks suspend by returning an error from its suspend hook. > > In particular I'm suggesting you ditch the /dev/suspend_block thing. > > With a single suspend manager process that manages the suspend state you > can achieve the same goal. > Yes we don't need the /dev interface, but it is useful. Without it any program that needs to block suspend has to make a blocking ipc call into the suspend manager process. Android already does this for java code, but system processes written in C block suspend directly with the kernel since they cannot use the java APIs. > When the suspend manager has a !0 busy-task count, it ensures the kernel > won't auto-suspend, when it again reaches a 0 busy-task count, it > re-instates the auto-suspend feature. > > That's pretty much what that device would do too. > > Ideally we would not do the auto-suspend thing at all and have > runtime-PM improved. Not running apps when they expect to run is like > the world turned upside down. > > 'Evil' apps could always report themselves as blocker anyway. > -- Arve Hjønnevåg