From: Dave Young <hidave.darkstar@gmail.com>
To: Brandon Philips <brandon@ifup.org>
Cc: Torsten Kaiser <just.for.lkml@googlemail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Chris Clayton <chris2553@googlemail.com>
Subject: Re: [PATCH] bttv: fix mutex use before init
Date: Wed, 15 Dec 2010 10:42:50 +0800 [thread overview]
Message-ID: <AANLkTimJrj6TY4BQ1BCd2USjudmLiY9AntWXmRzFWgn_@mail.gmail.com> (raw)
In-Reply-To: <20101214214306.GC5900@hanuman.home.ifup.org>
On Wed, Dec 15, 2010 at 5:43 AM, Brandon Philips <brandon@ifup.org> wrote:
> On 21:56 Tue 14 Dec 2010, Torsten Kaiser wrote:
>> On Tue, Dec 14, 2010 at 1:30 AM, Brandon Philips <brandon@ifup.org> wrote:
>> > On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote:
>> >> * change &fh->cap.vb_lock in bttv_open() AND radio_open() to
>> >> &btv->init.cap.vb_lock
>> >> * add a mutex_init(&btv->init.cap.vb_lock) to the setup of init in bttv_probe()
>> >
>> > That seems like a reasonable suggestion. An openSUSE user submitted this
>> > bug to our tracker too. Here is the patch I am having him test.
>> >
>> > Would you mind testing it?
>>
>> No. :-)
>>
>> Without this patch (==vanilla 2.6.37-rc5) I got 2 more OOPSe by
>> restarting hal around 20 times.
>> After applying this patch, I did not see a single OOPS after 100 restarts.
>> So it looks like the fix is correct.
>
> Dave, Torsten- Great thanks for testing, can I get both you and Dave's
> Tested-by then?
Feel free to add my tested-by line for this, Thanks
>
> Mauro- can you please pick up this patch?
>
> Cheers,
>
> Brandon
>
--
Regards
dave
next prev parent reply other threads:[~2010-12-15 2:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 13:15 Dave Young
2010-12-12 16:13 ` Torsten Kaiser
2010-12-13 14:04 ` Dave Young
2010-12-13 19:06 ` Torsten Kaiser
2010-12-14 0:30 ` Brandon Philips
2010-12-14 12:05 ` Dave Young
2010-12-14 20:56 ` Torsten Kaiser
2010-12-14 21:13 ` Torsten Kaiser
2010-12-14 21:48 ` Brandon Philips
2010-12-14 21:43 ` Brandon Philips
2010-12-15 2:42 ` Dave Young [this message]
2010-12-15 6:47 ` Torsten Kaiser
2010-12-15 18:44 ` Chris Clayton
2010-12-15 21:45 ` Mauro Carvalho Chehab
2010-12-16 17:26 ` Chris Clayton
2010-12-17 14:05 ` Torsten Kaiser
2010-12-17 16:07 ` Brandon Philips
2010-12-17 20:11 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimJrj6TY4BQ1BCd2USjudmLiY9AntWXmRzFWgn_@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=brandon@ifup.org \
--cc=chris2553@googlemail.com \
--cc=g.liakhovetski@gmx.de \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®