From: Fubo Chen <fubo.chen@gmail.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Mike Christie <michaelc@cs.wisc.edu>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@suse.de>,
Jens Axboe <axboe@kernel.dk>, Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [RFC 15/22] tcm: Add FILEIO subsystem plugin
Date: Mon, 20 Sep 2010 18:18:21 +0200 [thread overview]
Message-ID: <AANLkTimPh+SNroYoavomwVtQ5UHsr7Lsq_229Vkbc1CB@mail.gmail.com> (raw)
In-Reply-To: <1283160144-6848-1-git-send-email-nab@linux-iscsi.org>
On Mon, Aug 30, 2010 at 11:22 AM, Nicholas A. Bellinger
<nab@linux-iscsi.org> wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch adds the O_SYNC FILEIO subsystem plugin for accessing struct file
> using Linux/VFS struct file_operations. It also includes WriteCache and FUA
> Write Emulation support to struct file using fs/sync.c/vfs_fsync_range()
>
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
>
> [ ... ]
>
> +static int fd_do_writev(struct fd_request *req, struct se_task *task)
> +{
> + struct file *fd = req->fd_dev->fd_file;
> + struct scatterlist *sg = task->task_sg;
> + struct iovec iov[req->fd_sg_count];
Kernel stack size is 8 KB. On a 64-bit system struct iovec takes 16
bytes. What happens if req->fd_sg_count is large ? Kernel crash ?
Fubo.
next prev parent reply other threads:[~2010-09-20 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 9:22 Nicholas A. Bellinger
2010-09-20 16:18 ` Fubo Chen [this message]
2010-09-22 7:29 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimPh+SNroYoavomwVtQ5UHsr7Lsq_229Vkbc1CB@mail.gmail.com \
--to=fubo.chen@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®