From: Ming Lei <tom.leiming@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Balaji T K <balajitk@ti.com>, Rajendra Nayak <rnayak@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] mfd: speedup twl4030 irq response time and decrease irq disable time
Date: Tue, 28 Sep 2010 13:01:32 +0800 [thread overview]
Message-ID: <AANLkTimT8WkgiCANL4tXcNgnm63oMnO2d2bKjDD1chJv@mail.gmail.com> (raw)
In-Reply-To: <20100928042416.GA9359@opensource.wolfsonmicro.com>
CC genirq guys
2010/9/28 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Tue, Sep 28, 2010 at 08:25:24AM +0800, Ming Lei wrote:
>> 2010/9/27 Samuel Ortiz <sameo@linux.intel.com>:
>
>> > Wouldn't converting your twl4030_irq_thread() to the threaded IRQ framework
>> > fix that problem ?
>
>> IRQ_DISABLED flag is set by disable_irq_nosync called from PIH handler,
>> then thread function can't be executed in irq thread function, so we can't
>> convert this to threaded IRQ framework simply.
>
> Have you raised this issue with the genirq guys? This sounds like
> something that the core infrastructure should be able to cope with.
>
Even genirq guys can help us to convert to irq thread framework, I
don't think there is good way to set priority for one irq thread.
For twl4030, if we can make twl4030_irq_thread to run at higher
priority than that of other irq thread, the PIH irq disable time can be
decreased further since other irq thread waken up by twl4030_irq_thread
can preempt the running of twl4030_irq_thread, and the PIH irq will be
enabled until complete of twl4030_irq_thread.
thanks,
--
Lei Ming
next prev parent reply other threads:[~2010-09-28 5:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 1:49 tom.leiming
2010-09-27 14:31 ` Ming Lei
2010-09-27 15:48 ` Samuel Ortiz
2010-09-28 0:25 ` Ming Lei
2010-09-28 4:24 ` Mark Brown
2010-09-28 5:01 ` Ming Lei [this message]
2010-09-28 5:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimT8WkgiCANL4tXcNgnm63oMnO2d2bKjDD1chJv@mail.gmail.com \
--to=tom.leiming@gmail.com \
--cc=balajitk@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rnayak@ti.com \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®