From: Rabin Vincent <rabin@rab.in>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ux500: Add Rohm BH1780GLI Light Sensor to i2c_board_info
Date: Tue, 11 Jan 2011 21:38:07 +0530 [thread overview]
Message-ID: <AANLkTimvS9rmrn86-veK3KwP31bqN7mzp2bEiwPEt_RR@mail.gmail.com> (raw)
In-Reply-To: <1294751426-3472-1-git-send-email-lee.jones@linaro.org>
On Tue, Jan 11, 2011 at 18:40, Lee Jones <lee.jones@linaro.org> wrote:
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-ux500/board-mop500.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c
> index 2635bb7..ff67408 100644
> --- a/arch/arm/mach-ux500/board-mop500.c
> +++ b/arch/arm/mach-ux500/board-mop500.c
> @@ -134,6 +134,15 @@ static struct i2c_board_info mop500_i2c0_devices[] = {
> },
> };
>
> +static struct i2c_board_info mop500_i2c2_devices[] = {
> +#if defined(CONFIG_SENSORS_BH1780)
> + {
> + /* Light sensor Rohm BH1780GLI */
> + I2C_BOARD_INFO("bh1780", 0x29),
> + },
> +#endif
> +};
You need to take care of the case where the driver is built as a module
(by adding a || defined(..._MODULE)). It would actually be better if
you instead get rid of the ifdef entirely, since they get really ugly if
you add them for every device here.
prev parent reply other threads:[~2011-01-11 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 13:10 Lee Jones
2011-01-11 16:08 ` Rabin Vincent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimvS9rmrn86-veK3KwP31bqN7mzp2bEiwPEt_RR@mail.gmail.com \
--to=rabin@rab.in \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®