From: Sedat Dilek <sedat.dilek@googlemail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Greg KH <gregkh@suse.de>
Subject: Re: [2.6.37-rc1-git11] none-BKL-config: stradis.c: error: implicit declaration of function ‘lock_kernel’/‘unlock_kernel’
Date: Mon, 15 Nov 2010 13:02:11 +0100 [thread overview]
Message-ID: <AANLkTimwSBo9tJUqBHAOBwLWmybOXdAPSY8Wx8bU_C7o@mail.gmail.com> (raw)
In-Reply-To: <201011151254.10277.arnd@arndb.de>
On Mon, Nov 15, 2010 at 12:54 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Sunday 14 November 2010, Sedat Dilek wrote:
>> with 2.6.37-rc1-git11 my none-BKL-config breaks (-git9 and -git9457b24
>> were OK) in stradis staging-crap.
>> Think the breakage aroses from [1].
>>
>> $ cd ~/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none
>>
>> $ grep "error:" ../../../../build_linux-2.6_git11.sd.1.log
>> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1891:
>> error: implicit declaration of function ‘lock_kernel’
>> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1897:
>> error: implicit declaration of function ‘unlock_kernel’
>
> The driver is on its way out. I'll do a patch to just mark it "depends
> on BKL" to make sure it doesn't get built when BKL is disabled.
>
> It would be relatively easy to fix the right way, if you are interested.
>
> Arnd
>
I was enjoying the nice sunshine weather on Sunday :-)... here in
South-West Germany.
Thus I had not had big time to look into the code... as stradis moved
to staging area, it got built this time in a none-BKL-config.
I checked a previous kernel and its dot-config and there was no
stradis inside, so never built before.
As stradis is marked DEPRECATED and I am not using it (even dunno what
it is, sorry for my ignorance), it's not that important.
A "depends on BKL" would be nice for the none-BKL-config folks to not
fall into the "pitfall".
If you have a patch for stradis, I would add it to my patchset.
Thank you in advance for helping to fix the issue.
- Sedat -
next prev parent reply other threads:[~2010-11-15 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 10:00 Sedat Dilek
2010-11-15 11:54 ` Arnd Bergmann
2010-11-15 12:02 ` Sedat Dilek [this message]
2010-11-16 0:28 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimwSBo9tJUqBHAOBwLWmybOXdAPSY8Wx8bU_C7o@mail.gmail.com \
--to=sedat.dilek@googlemail.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®