From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250Ab0ILIGj (ORCPT ); Sun, 12 Sep 2010 04:06:39 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:64751 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019Ab0ILIGS convert rfc822-to-8bit (ORCPT ); Sun, 12 Sep 2010 04:06:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=WHQqNxAYiVTk/mFytjD/zQIcO0ELfsTxj097t1cj/MqCiWRcAHa9yqlNiYLxzZX0ku 8Y3/5tkq8mUo27g1xdnBQQ/EOk4C8P5c/yjCnKOyuv6Owi8Dqw1heQb+h8EjuwBIpcoO snVaxHcwnWj4DNFFKSlXIIfRNgd9m79lNN/HA= MIME-Version: 1.0 In-Reply-To: <1284107570-17124-1-git-send-email-bebarino@gmail.com> References: <1284107570-17124-1-git-send-email-bebarino@gmail.com> Date: Sun, 12 Sep 2010 11:06:16 +0300 Message-ID: Subject: Re: [PATCH] nconfig: Fix help for choice menus From: Nir Tzachar To: Michal Marek Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, bebarino@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 10, 2010 at 11:32 AM, Stephen Boyd wrote: > When getting the help for a choice menu with a help section (for example > the "Choose SLAB allocator" menu) nconfig pops up a window with nothing > inside it. This is due to show_help() passing an empty string to > show_scroll_win()'s 3rd argument. The option really does have help > though, but it isn't a config symbol, so just add the help text for > the option, and don't try to add anything else like the config option > name. Acked-by: Nir Tzachar > Signed-off-by: Stephen Boyd > Cc: Nir Tzachar > --- >  scripts/kconfig/nconf.c |    2 ++ >  1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c > index 2ba71bc..19d3401 100644 > --- a/scripts/kconfig/nconf.c > +++ b/scripts/kconfig/nconf.c > @@ -1252,6 +1252,8 @@ static void show_help(struct menu *menu) >                        str_append(&help, _(menu_get_help(menu))); >                        str_append(&help, "\n"); >                        get_symbol_str(&help, menu->sym); > +               } else { > +                       str_append(&help, _(menu_get_help(menu))); >                } >        } else { >                str_append(&help, nohelp_text); > -- > 1.7.2.3.313.gcd15 > >