mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Greg KH <gregkh@suse.de>
Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver-core: remove conditionals around devicetree pointers
Date: Tue, 25 Jan 2011 21:19:36 -0700	[thread overview]
Message-ID: <AANLkTinf6+FN90tyLd6f1guvppt5s5PQL3ZkcecCCX+E@mail.gmail.com> (raw)
In-Reply-To: <20110126031734.GA1636@suse.de>

On Tue, Jan 25, 2011 at 8:17 PM, Greg KH <gregkh@suse.de> wrote:
> On Tue, Jan 25, 2011 at 07:02:02PM -0700, Grant Likely wrote:
>> Having conditional around the of_match_table and the of_node pointers
>> turns out to make driver code use ugly #ifdef blocks.  Drop the
>> conditionals and remove the #ifdef blocks from the affected drivers.
>>
>> Also tidy up minor whitespace issues within the same hunks.
>>
>> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>> ---
>>
>> I've held off doing this since I didn't want to needlessly increase
>> the size of struct device and struct device_driver for users who don't
>> use CONFIG_OF.  However, its quibbling about a tiny amount of memory,
>> and #ifdef'ing it out this way is ugly for driver code.
>>
>> Alternately, if I should be concerned about the extra memory, I could
>> define some macros/inlines similar to how CONFIG_NUMA is handled.
>
> No objection from me, I was wondering when you would get around to doing
> this :)
>
> If you want me to take this in my tree, I'd be glad to, otherwise feel
> free to send it through yours, and add a:
>        Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> to it.

Thanks.  I'll take it via my tree.

g.

>
> Nice job,
>
> greg k-h
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

      reply	other threads:[~2011-01-26  4:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  2:02 Grant Likely
2011-01-26  3:17 ` Greg KH
2011-01-26  4:19   ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinf6+FN90tyLd6f1guvppt5s5PQL3ZkcecCCX+E@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®