From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CB7CD37BB for ; Sat, 16 Sep 2023 12:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236231AbjIPMxm (ORCPT ); Sat, 16 Sep 2023 08:53:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbjIPMxc (ORCPT ); Sat, 16 Sep 2023 08:53:32 -0400 X-Greylist: delayed 166 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 16 Sep 2023 05:53:27 PDT Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [81.169.146.164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5319F1AD for ; Sat, 16 Sep 2023 05:53:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694868625; cv=none; d=strato.com; s=strato-dkim-0002; b=o5MOFDs3o3UEwlFDwmjNztUBwR9RUtixGxBfVoenquODhIcNgNf3Kuo29PDoxO2mD8 vc2dRVOZEuzj0uq6u9PmItU3Upb7ACtwISNFNrCLfEKFoVgdCQmj4he4igwgI/a9HwiE Bhp79hwQcEC0AU9o5hznLQLcasDvRiWF/4LewUV90BTFAkGn2P4I/h2CD0Tg6NWS+hc6 /j0PD+ajS9nAEtQdCo669yNIM4QIiScOFFpp4/phWrewQfcQvhlPOHH2xPL1ygQDah5R B6qTUg1+W9OV3Vkg6ARwyFXEOuQbI4AKBBcbG096ux56G1+IvdqoYhXYiLoRf0pRtzpw 3ucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1694868625; s=strato-dkim-0002; d=strato.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=/AAXy58L/sWU6ITVYngidAH9QYdMsJXYQ4py7+FutQ4=; b=MV5z5cdfGY1OQZ9BKAr8LDEwCZvocCHZEh/WbQGM8g2HHVMgi+0+PAKk1ml11EQVcB NeLMCLXxUBF+4/qMo3TiGo/jmHiUXwBD9eXGj3eQEg39Ztjs5+nOCD00pJNdhyFygBRh wKhs5v6yk7G/kYi7wpv92Ldg/66PzkphF3//OtItvHqDt9Y1ZMoAkcoplfBBV7vOxdvS xhLKqB5+ocFlRGBT5uMctf6M9t3P7KOBDXJVFydz98QBkZKx4DGGSGzshT9HGfw5icH6 0XtR5F+lFeWTYyBt2HhQzobP166FpdQ326v9E21Ruk6jLESFaX3cNE40jiLU1edMusA1 nDrg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1694868625; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=/AAXy58L/sWU6ITVYngidAH9QYdMsJXYQ4py7+FutQ4=; b=mTP2O5O0jB3ZGYjSXJ9iHc+qpk1PW6BvmQ9+xL/u/2A+KHmQ+Zrqa5PgA/2Du8l2yf /4eArdmsyYO/BJYrqdb8Binyz7nQDG5HjS6fr2aMkAjI6Cp1Lz8W+RupdggV+jRtKKlB 0fib3CQfWMO5CBUAowXjrym9HNeYrx6dIRGl0eHpntoQpMrq3r+nu3tasWX9nP62MMzJ s1LC9K8p5Q347GUpJ6FFOPJwPp9oF2QpxeBxSBX3JC/CHPg4O0OngIQRNOXTyMZ6peRJ uojR8OOr7UBX9q/piuWWqr168tOZ85MJIIOtXTVCQOx0HPV3bFBecNJuUSwI2yHueHM9 SRFA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1694868625; s=strato-dkim-0003; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=/AAXy58L/sWU6ITVYngidAH9QYdMsJXYQ4py7+FutQ4=; b=cVOyXAlTBnidaQht9zOf1LPiq+rbQ9mZOQhLD4DgmquK28rbDDqKHU1O3LwNsdjfH5 AtP8Bk5+gUBjpNCMBwAg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Apz9PSN6LgsXcGZiDY=" Received: from smtpclient.apple by smtp.strato.de (RZmta 49.8.2 DYNA|AUTH) with ESMTPSA id Y04dd7z8GCoOWOm (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 16 Sep 2023 14:50:24 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings From: "H. Nikolaus Schaller" In-Reply-To: <9daacd2f-0dbf-dddc-9403-b802447896a2@ideasonboard.com> Date: Sat, 16 Sep 2023 14:50:24 +0200 Cc: Laurent Pinchart , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230412073954.20601-1-tony@atomide.com> <9daacd2f-0dbf-dddc-9403-b802447896a2@ideasonboard.com> To: Tomi Valkeinen , Tony Lindgren X-Mailer: Apple Mail (2.3696.120.41.1.4) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi and Tony, > Am 13.09.2023 um 13:59 schrieb Tomi Valkeinen = : >=20 > On 12/04/2023 10:39, Tony Lindgren wrote: >> We may not have dsi->dsidev initialized during probe, and that can >> lead into various dsi related warnings as omap_dsi_host_detach() gets >> called with dsi->dsidev set to NULL. >> The warnings can be "Fixed dependency cycle(s)" followed by a >> WARNING: CPU: 0 PID: 787 at drivers/gpu/drm/omapdrm/dss/dsi.c:4414. >> Let's fix the warnings by checking for a valid dsi->dsidev. >> Signed-off-by: Tony Lindgren >> --- >> drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c = b/drivers/gpu/drm/omapdrm/dss/dsi.c >> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c >> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c >> @@ -4411,7 +4411,7 @@ static int omap_dsi_host_detach(struct = mipi_dsi_host *host, >> { >> struct dsi_data *dsi =3D host_to_omap(host); >> - if (WARN_ON(dsi->dsidev !=3D client)) >> + if (dsi->dsidev && WARN_ON(dsi->dsidev !=3D client)) >> return -EINVAL; >> cancel_delayed_work_sync(&dsi->dsi_disable_work); >=20 > Shouldn't this rather be >=20 > if (!dsi->dsidev) > return 0; >=20 > before the if (WARN_ON(dsi->dsidev !=3D client)) line? Yes you are right. We have a different variant in our Pyra kernel: What we currently have in our Pyra tree is: = https://git.goldelico.com/?p=3Dletux-kernel.git;a=3Dcommitdiff;h=3D5bf7bd6= 4eec1eb924e794e8d6600919f0dae8c5a;hp=3D27a0cd6263194d1465e9c53293d35f8c8c9= 88f9d struct dsi_data *dsi =3D host_to_omap(host); =20 - if (WARN_ON(dsi->dsidev !=3D client)) +printk("%s\n", __func__); + + if (!dsi->dsidev || WARN_ON(dsi->dsidev !=3D client)) return -EINVAL; =20 cancel_delayed_work_sync(&dsi->dsi_disable_work); >=20 > If dsi->dsidev is NULL, then attach hasn't been called, and we = shouldn't do anything in the detach callback either. >=20 > With your change we'll end up doing all the work in the detach = callback, without ever doing their counterpart in the attach side. If useful, I can post above mentioned patch (without printk). BR and thanks, Nikolaus