From: Jeongjun Park <aha310510@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
idosch@nvidia.com, jiri@resnulli.us, amcohen@nvidia.com,
liuhangbin@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+b668da2bc4cb9670bf58@syzkaller.appspotmail.com
Subject: Re: [PATCH net] rtnetlink: fix possible deadlock in team_port_change_check
Date: Wed, 31 Jul 2024 10:37:38 +0900 [thread overview]
Message-ID: <AB56B530-B67F-4A41-99E7-1FDA14604D5F@gmail.com> (raw)
In-Reply-To: <20240730165912.67600510@kernel.org>
> 2024. 7. 31. 오전 8:59, Jakub Kicinski <kuba@kernel.org> 작성:
>
> On Wed, 31 Jul 2024 00:22:10 +0900 Jeongjun Park wrote:
>> do_setlink() changes the flag of the device and then enslaves it. However,
>> in this case, if the IFF_UP flag is set, the enslavement process calls
>> team_add_slave() to acquire 'team->lock', but when dev_open() opens the
>> newly enslaved device, the NETDEV_UP event occurs, and as a result,
>> a deadlock occurs when team_port_change_check() tries to acquire
>> 'team->lock' again.
>
> You can't change behavior like this, see ec4ffd100ffb396ec
Okay. In that case, I'll write a patch that modifies the code of the team driver and send
it back to you.
Regards,
Jeongjun Park
prev parent reply other threads:[~2024-07-31 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 15:22 Jeongjun Park
2024-07-30 23:59 ` Jakub Kicinski
2024-07-31 1:37 ` Jeongjun Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AB56B530-B67F-4A41-99E7-1FDA14604D5F@gmail.com \
--to=aha310510@gmail.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+b668da2bc4cb9670bf58@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®