From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va-1-114.ptr.blmpb.com (va-1-114.ptr.blmpb.com [209.127.230.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD56B33A6E9 for ; Fri, 3 Apr 2026 14:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.230.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775225598; cv=none; b=EOFIe/XHaMCZrvsiEOkZCj4pjm+sq/Y5cl+oQufeQgI4MDdb3FukGq8LLZpfmf+3yqdJCvOfbS+nHxPb8lMXFOSZ9tJZ9aWY2Fv7Z55rw7zbnrc8CS/ivojFL9B6f7lW5tT8MDxsYrUBuDZ7i0YCSm8Te6wpTO8yIfLJC6wh75k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775225598; c=relaxed/simple; bh=fdISPl4YJ1vy4PA0uwfnX9nTXGBMu4uSeXUCkzltRFU=; h=To:Content-Type:From:Message-Id:Mime-Version:References: In-Reply-To:Cc:Subject:Date; b=LC/x1U0Q1gB2rsmwqVgSkljgrs55H9PACV4wg2RlI7JZok0TQieH/e7EBzSs1OV5F90cRcDzMct9jJS22YwL1JsuBKaIB7Q86m99QoQlrduXraYMENXNFvjt+kUFh8OjhvCWtpPZoQc1D5Dviq5P+DTCO7rfHEpgn6LVNi1h/M8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=D6WM3M8f; arc=none smtp.client-ip=209.127.230.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="D6WM3M8f" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1775225589; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=Hs8hHyHneBqa2LNiQ0ukRmSws3LttUDjkH/7Zln8IIE=; b=D6WM3M8fe0zyFkhepE9R2KP1NygFz9bQDeZMjOTYxdIKV5EpxIb8azT7nPpQI16bTcjiAh BBPDhdXEdCNDsg3sYlWSe20aTYU/6sJQR3xU4zbUR1A97nm/QPnuA6zK3F5O8QGfeM729M 46/J+keVqh1z6OCbTu/OlkwakywKNWCAYpfZgowCE2Aqos08xOo3tZVInnw/6MH7pBgI8h ncrEfuYDWBzd/Jula6yq7MRoSK/W40T1caomZ67iwOBzLeYeUSyF8FFnAQQOmJrTnHI9Kg 4slKn7Ozmbwj+UXPb69XRhiR75PxC0mzlBoINbuipKpSQz1LdG2mUKho10Yspg== To: "Corey Minyard" Content-Type: text/plain; charset=UTF-8 From: "Jian Zhang" Message-Id: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260403090603.3988423-1-zhangjian.3032@bytedance.com> <20260403090603.3988423-5-zhangjian.3032@bytedance.com> In-Reply-To: X-Original-From: Jian Zhang Cc: "Quan Nguyen" , , Subject: Re: [PATCH v2 5/5] ipmi: ssif_bmc: add unit test for state machine Date: Fri, 3 Apr 2026 22:12:45 +0800 X-Lms-Return-Path: X-Mailer: Apple Mail (2.3776.700.51.11.4) Content-Transfer-Encoding: quoted-printable > 2026=E5=B9=B44=E6=9C=883=E6=97=A5 21:14=EF=BC=8CCorey Minyard =E5=86=99=E9=81=93=EF=BC=9A >=20 > On Fri, Apr 03, 2026 at 05:06:02PM +0800, Jian Zhang wrote: >> Add some unit test for state machine when in SSIF_ABORTING state. >>=20 >> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") >> Signed-off-by: Jian Zhang >> --- >> v2: remove undefined symbol response_in_send >>=20 >> drivers/char/ipmi/Kconfig | 10 + >> drivers/char/ipmi/ssif_bmc.c | 401 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 411 insertions(+) >>=20 >> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig >> index 92bed266d07c..709820f80266 100644 >> --- a/drivers/char/ipmi/Kconfig >> +++ b/drivers/char/ipmi/Kconfig >> @@ -187,6 +187,16 @@ config SSIF_IPMI_BMC >> The driver implements the BMC side of the SMBus system >> interface (SSIF). >>=20 >> +config SSIF_IPMI_BMC_KUNIT_TEST >> + bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS >> + depends on KUNIT=3Dy >> + depends on SSIF_IPMI_BMC=3Dy >=20 > Any reason for the "=3Dy" in the above two? >=20 > It's best to remove them if they are not needed so it can work in a > module. I can make that change, there's no need for a new series for > that. Nothing special and agree, Thanks. There=E2=80=99s one more thing that needs adjustment as well.=20 Sorry about that=E2=80=94I picked it from dev-6.1 without testing (at the t= ime there was a build error, so I didn=E2=80=99t run the unit tests).=20 The test =E2=80=9Cssif_bmc_test_restart_after_invalid_length=E2=80=9D also = needs to be removed. I do have a local patch regarding the length limitatio= n, but it still needs thorough testing. Sorry again, I=E2=80=99m not very fam= iliar with it yet, I=E2=80=99ll pay more attention in the future! - Jian >=20 > Oh, and I forgot to say in the reply on the first change, thanks Quan > for reviewing these. >=20 > -corey >=20 >> + default KUNIT_ALL_TESTS >> + help >> + This option builds unit tests that exercise the SSIF BMC state >> + machine, including request handling, response transmission, >> + and error paths such as aborted or truncated transfers. >> + >> config IPMB_DEVICE_INTERFACE >> tristate 'IPMB Interface handler' >> depends on I2C >> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c >> index 646a1e9ffbb7..726626126cea 100644 >> --- a/drivers/char/ipmi/ssif_bmc.c >> +++ b/drivers/char/ipmi/ssif_bmc.c >> @@ -18,6 +18,9 @@ >> #include >> #include >> #include >> +#if IS_ENABLED(CONFIG_SSIF_IPMI_BMC_KUNIT_TEST) >> +#include >> +#endif >>=20 >> #define DEVICE_NAME "ipmi-ssif-host" >>=20 >> @@ -886,6 +889,404 @@ static struct i2c_driver ssif_bmc_driver =3D { >> .id_table =3D ssif_bmc_id, >> }; >>=20 >> +#if IS_ENABLED(CONFIG_SSIF_IPMI_BMC_KUNIT_TEST) >> +struct ssif_bmc_test_ctx { >> + struct ssif_bmc_ctx ssif_bmc; >> + struct i2c_client client; >> + struct i2c_adapter adapter; >> + struct i2c_algorithm algo; >> +}; >> + >> +static int ssif_bmc_test_init(struct kunit *test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx; >> + >> + test_ctx =3D kunit_kzalloc(test, sizeof(*test_ctx), GFP_KERNEL); >> + if (!test_ctx) >> + return -ENOMEM; >> + >> + test_ctx->adapter.algo =3D &test_ctx->algo; >> + test_ctx->client.addr =3D 0x20; >> + test_ctx->client.adapter =3D &test_ctx->adapter; >> + >> + spin_lock_init(&test_ctx->ssif_bmc.lock); >> + init_waitqueue_head(&test_ctx->ssif_bmc.wait_queue); >> + test_ctx->ssif_bmc.client =3D &test_ctx->client; >> + i2c_set_clientdata(&test_ctx->client, &test_ctx->ssif_bmc); >> + >> + test->priv =3D test_ctx; >> + >> + return 0; >> +} >> + >> +static void ssif_bmc_test_exit(struct kunit *test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + >> + if (test_ctx->ssif_bmc.response_timer_inited) >> + timer_delete_sync(&test_ctx->ssif_bmc.response_timer); >> +} >> + >> +static int ssif_bmc_test_run_event_val(struct ssif_bmc_test_ctx *test_c= tx, >> + enum i2c_slave_event event, >> + u8 *value) >> +{ >> + return ssif_bmc_cb(&test_ctx->client, event, value); >> +} >> + >> +static int ssif_bmc_test_run_event(struct ssif_bmc_test_ctx *test_ctx, >> + enum i2c_slave_event event, u8 value) >> +{ >> + return ssif_bmc_test_run_event_val(test_ctx, event, &value); >> +} >> + >> +static void ssif_bmc_test_singlepart_req(struct kunit *test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)); >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE); >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 2); >> + >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xaa); >> + >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x55); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); >> + >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->busy); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->aborting); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 2); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0xaa); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[1], 0x55); >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->response_timer_inited); >> +} >> + >> +static void ssif_bmc_test_restart_write_without_stop(struct kunit *test= ) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 2), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xde), 0); >> + >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_REQ_RECVING); >> + >> + /* Write transaction, without stop, and new request coming */ >> + ssif_bmc_test_singlepart_req(test); >> +} >> + >> + >> +static void ssif_bmc_test_restart_after_invalid_command(struct kunit *t= est) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xff), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); >> + >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_ABORTING); >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->aborting); >> + >> + /* After An Invalid Command, expect could handle new request */ >> + ssif_bmc_test_singlepart_req(test); >> +} >> + >> +static void ssif_bmc_test_restart_after_invalid_length(struct kunit *te= st) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + int i; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + MAX_PAYLOAD_PER_TRANSACTION + 1), 0); >> + >> + for (i =3D 0; i < MAX_PAYLOAD_PER_TRANSACTION + 1; i++) >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, >> + I2C_SLAVE_WRITE_RECEIVED, i), 0); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->aborting); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_REQ_RECVING); >> + >> + ssif_bmc_test_singlepart_req(test); >> +} >> + >> +static void ssif_bmc_test_singlepart_read_response_completion(struct ku= nit *test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + u8 value; >> + >> + ssif_bmc->state =3D SSIF_SMBUS_CMD; >> + ssif_bmc->part_buf.smbus_cmd =3D SSIF_IPMI_SINGLEPART_READ; >> + ssif_bmc->response.len =3D 2; >> + ssif_bmc->response.payload[0] =3D 0x11; >> + ssif_bmc->response.payload[1] =3D 0x22; >> + ssif_bmc->response_in_progress =3D true; >> + ssif_bmc->is_singlepart_read =3D true; >> + ssif_bmc->pec_support =3D true; >> + >> + value =3D 0; >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, value, 2); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); >> + >> + value =3D 0; >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, value, 0x11); >> + >> + value =3D 0; >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, value, 0x22); >> + >> + value =3D 0; >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, value, ssif_bmc->part_buf.pec); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_progress); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->response.len, 0); >> +} >> + >> +static void ssif_bmc_test_stop_during_start_discards_partial_request(st= ruct kunit *test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_START); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->msg_idx, 0); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x77), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); >> + >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 1); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0x77); >> +} >> + >> +static void ssif_bmc_test_read_interrupts_partial_write(struct kunit *t= est) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + u8 value =3D 0xff; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 2), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xab), 0); >> + >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_REQ_RECVING); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, value, 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_ABORTING); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 0); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xcd), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); >> + >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 1); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0xcd); >> +} >> + >> +static void ssif_bmc_test_write_interrupts_response_send(struct kunit *= test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + u8 value =3D 0; >> + >> + ssif_bmc->state =3D SSIF_SMBUS_CMD; >> + ssif_bmc->part_buf.smbus_cmd =3D SSIF_IPMI_SINGLEPART_READ; >> + ssif_bmc->response.len =3D 1; >> + ssif_bmc->response.payload[0] =3D 0x66; >> + ssif_bmc->response_in_progress =3D true; >> + ssif_bmc->is_singlepart_read =3D true; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); >> + >> + /* READ_REQUESTED transaction */ >> + ssif_bmc_test_singlepart_req(test); >> +} >> + >> +static void ssif_bmc_test_write_interrupts_response_sending(struct kuni= t *test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + u8 value =3D 0; >> + >> + ssif_bmc->state =3D SSIF_SMBUS_CMD; >> + ssif_bmc->part_buf.smbus_cmd =3D SSIF_IPMI_SINGLEPART_READ; >> + ssif_bmc->response.len =3D 1; >> + ssif_bmc->response.payload[0] =3D 0x66; >> + ssif_bmc->response_in_progress =3D true; >> + ssif_bmc->is_singlepart_read =3D true; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, >> + &value), 0); >> + KUNIT_EXPECT_EQ(test, value, 0x66); >> + >> + /* READ_REQUESTED transaction */ >> + ssif_bmc_test_singlepart_req(test); >> +} >> + >> +static void ssif_bmc_test_timeout_interrupt_allows_retry(struct kunit *= test) >> +{ >> + struct ssif_bmc_test_ctx *test_ctx =3D test->priv; >> + struct ssif_bmc_ctx *ssif_bmc =3D &test_ctx->ssif_bmc; >> + >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x21), 0); >> + KUNIT_ASSERT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); >> + >> + KUNIT_ASSERT_TRUE(test, timer_pending(&ssif_bmc->response_timer)); >> + timer_delete_sync(&ssif_bmc->response_timer); >> + response_timeout(&ssif_bmc->response_timer); >> + >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->busy); >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->aborting); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->response_timer_inited); >> + >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, >> + SSIF_IPMI_SINGLEPART_WRITE), 0); >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->aborting); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x22), 0); >> + KUNIT_EXPECT_EQ(test, >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); >> + >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 1); >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0x22); >> +} >> + >> +static struct kunit_case ssif_bmc_test_cases[] =3D { >> + KUNIT_CASE(ssif_bmc_test_singlepart_req), >> + KUNIT_CASE(ssif_bmc_test_restart_write_without_stop), >> + KUNIT_CASE(ssif_bmc_test_restart_after_invalid_command), >> + KUNIT_CASE(ssif_bmc_test_restart_after_invalid_length), >> + KUNIT_CASE(ssif_bmc_test_singlepart_read_response_completion), >> + KUNIT_CASE(ssif_bmc_test_stop_during_start_discards_partial_request), >> + KUNIT_CASE(ssif_bmc_test_read_interrupts_partial_write), >> + KUNIT_CASE(ssif_bmc_test_write_interrupts_response_send), >> + KUNIT_CASE(ssif_bmc_test_write_interrupts_response_sending), >> + KUNIT_CASE(ssif_bmc_test_timeout_interrupt_allows_retry), >> + {} >> +}; >> + >> +static struct kunit_suite ssif_bmc_test_suite =3D { >> + .name =3D "ssif_bmc_test", >> + .init =3D ssif_bmc_test_init, >> + .exit =3D ssif_bmc_test_exit, >> + .test_cases =3D ssif_bmc_test_cases, >> +}; >> + >> +kunit_test_suite(ssif_bmc_test_suite); >> +#endif >> + >> module_i2c_driver(ssif_bmc_driver); >>=20 >> MODULE_AUTHOR("Quan Nguyen "); >> --=20 >> 2.20.1