From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67ECC32771 for ; Tue, 7 Jan 2020 03:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7031720707 for ; Tue, 7 Jan 2020 03:22:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="uKWJDe1i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727488AbgAGDWK (ORCPT ); Mon, 6 Jan 2020 22:22:10 -0500 Received: from terminus.zytor.com ([198.137.202.136]:48745 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727295AbgAGDWK (ORCPT ); Mon, 6 Jan 2020 22:22:10 -0500 Received: from [IPv6:2601:646:8600:3281:b19f:287a:bb58:115c] ([IPv6:2601:646:8600:3281:b19f:287a:bb58:115c]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id 0073LmUi3203176 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 6 Jan 2020 19:21:50 -0800 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 0073LmUi3203176 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019122001; t=1578367311; bh=/FJWxFmnQWfWatyrgKd0gVo3/yEc0bk99NQ6Gk5bK1U=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=uKWJDe1iemuHyEAzEU7Zf6bM5XhZk28w7prAkAj/A2n2tHCYWkySM3F5o7ldhQGx2 Q5U19RjwUQDEtwD04YoUiwRUdHUYdy4GqZ2i3SKt5hvSWOn7vaDgcOF9oUxvc/sihC ziAdaKTiqUV7eHWBuK9Rozb2T3cXTcA/gQSfs+bdm34V+KbgwzdhAxlAwRy/jjo1QM MwcIop9OosyJpzV79+sMJR03eoQBogoLSeuA0GhLI0fdWe2ZKHfgJQn3PpEugVljPv XUa8SFWgej4Ipa+KGD/9nSmP6UXc5fAcBOkAaXNnJRRSCWZvgL3dRESJQ2wwWv40H4 fAS/gzqHI75Kw== Date: Mon, 06 Jan 2020 19:21:40 -0800 User-Agent: K-9 Mail for Android In-Reply-To: References: <20200104150238.19834-1-masahiroy@kernel.org> <20200104150238.19834-5-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 04/13] initramfs: rename gen_initramfs_list.sh to gen_initramfs.sh To: Masahiro Yamada , Greg Thelen , Ben Hutchings CC: Linux Kbuild mailing list , Andrew Morton , Sam Ravnborg , Linux Kernel Mailing List From: hpa@zytor.com Message-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On January 6, 2020 2:26:22 AM PST, Masahiro Yamada = wrote: >(+CC Ben Hutchings, H=2E Peter Anvin) > >In my understanding, the klibc build system is standalone=2E >So, the change in Linux kernel does not affect klibc at all=2E >Only the depending part is UAPI headers (make headers_install)=2E > >So, this patch >(https://lore=2Ekernel=2Eorg/patchwork/patch/1175336/) >should be OK=2E > >Please correct me if I am wrong=2E > > >On Mon, Jan 6, 2020 at 4:43 PM Greg Thelen wrote: >> >> Masahiro Yamada wrote: >> >> > The comments in usr/Makefile wrongly refer to the script name >(twice)=2E >> > >> > Line 37: >> > # The dependency list is generated by gen_initramfs=2Esh -l >> > >> > Line 54: >> > # 4) Arguments to gen_initramfs=2Esh changes >> > >> > There does not exist such a script=2E >> > >> > I was going to fix the comments, but after some consideration, I >thought >> > "gen_initramfs=2Esh" would be more suitable than >"gen_initramfs_list=2Esh" >> > because it generates an initramfs image in the common usage=2E >> > >> > The script generates a list that can be fed to gen_init_cpio only >when >> > it is directly run without -o or -l option=2E >> > >> > Signed-off-by: Masahiro Yamada >> > --- >> > >> > Changes in v2: None >> > >> > usr/Makefile | 2 +- >> > usr/{gen_initramfs_list=2Esh =3D> gen_initramfs=2Esh} | 0 >> > 2 files changed, 1 insertion(+), 1 deletion(-) >> > rename usr/{gen_initramfs_list=2Esh =3D> gen_initramfs=2Esh} (100%) >> >> Will this break klibc? It might have a ref to the old name=2E >> >https://git=2Ekernel=2Eorg/pub/scm/libs/klibc/klibc=2Egit/tree/usr/Kbuild= #n55 > >I do not think so=2E > >As I stated above, the klibc build system is independent of >any script in the Linux kernel=2E > >The klibc Makefile refers to >scripts/gen_initramfs_list=2Esh, which does not exist=2E > >My path is renaming >usr/gen_initramfs_list=2Esh to usr/gen_initramfs=2Esh > > >If the renaming had been problematic for klibc, >commit f6f57a46435d7253a52a1a07a58183678ad266a0 >("initramfs: move gen_initramfs_list=2Esh from scripts/ to usr/") >would have already caused a problem=2E > > > >Ben, Hans, >Is usr/Kbuild in klibc used? >If it is not used, is it better to delete it to avoid confusion? > > >Masahiro Yamada > > > > >> > diff --git a/usr/Makefile b/usr/Makefile >> > index 55c942da01cd=2E=2Ee44a66b8c051 100644 >> > --- a/usr/Makefile >> > +++ b/usr/Makefile >> > @@ -24,7 +24,7 @@ $(obj)/initramfs_data=2Eo: $(obj)/$(datafile_y) >FORCE >> > # Generate the initramfs cpio archive >> > >> > hostprogs-y :=3D gen_init_cpio >> > -initramfs :=3D $(CONFIG_SHELL) >$(srctree)/$(src)/gen_initramfs_list=2Esh >> > +initramfs :=3D $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs=2Es= h >> > ramfs-input :=3D $(if $(filter-out "",$(CONFIG_INITRAMFS_SOURCE)), \ >> > $(shell echo $(CONFIG_INITRAMFS_SOURCE)),-d) >> > ramfs-args :=3D \ >> > diff --git a/usr/gen_initramfs_list=2Esh b/usr/gen_initramfs=2Esh >> > similarity index 100% >> > rename from usr/gen_initramfs_list=2Esh >> > rename to usr/gen_initramfs=2Esh That is correct=2E The klibc integration work was mainly fine in an actual kernel tree, which= pulled the klibc tree=2E It has obviously bitrotted somewhat, but it wouldn't be all that hard to r= esurrect it if there is ever interest=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E