From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030AbcAHEvW (ORCPT ); Thu, 7 Jan 2016 23:51:22 -0500 Received: from e17.ny.us.ibm.com ([129.33.205.207]:47193 "EHLO e17.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753718AbcAHEvU convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2016 23:51:20 -0500 X-IBM-Helo: d01dlp01.pok.ibm.com X-IBM-MailFrom: mrochs@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-scsi@vger.kernel.org Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1_hw() From: "Matthew R. Ochs" In-Reply-To: <1450697709-120516-4-git-send-email-john.garry@huawei.com> Date: Thu, 7 Jan 2016 22:51:10 -0600 Cc: James Bottomley , "Martin K. Petersen" , linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1450697709-120516-1-git-send-email-john.garry@huawei.com> <1450697709-120516-4-git-send-email-john.garry@huawei.com> To: John Garry X-Mailer: Apple Mail (2.2104) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010804-0041-0000-0000-000002FA7F27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Dec 21, 2015, at 5:35 AM, John Garry wrote: > > By reading in itct.qw0 into a 32b variable the top > 32 bits were being lost. > In practice this was OK as they were zeroes. > > Fixes: 27a3f229 ("hisi_sas: Add cq interrupt") > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > index 38ff575..057fdeb 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > @@ -539,7 +539,8 @@ static void free_device_v1_hw(struct hisi_hba *hisi_hba, > { > u64 dev_id = sas_dev->device_id; > struct hisi_sas_itct *itct = &hisi_hba->itct[dev_id]; > - u32 qw0, reg_val = hisi_sas_read32(hisi_hba, CFG_AGING_TIME); > + u64 qw0; This should probably be a __le64, but not a big deal. Reviewed-by: Matthew R. Ochs