mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Michael Kelley <mhklinux@outlook.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hyperv: Remove unused union and structs
Date: Mon, 10 Mar 2025 21:40:59 +0100	[thread overview]
Message-ID: <ACB6A959-C2CD-44E7-A1D6-AB9263C29D4D@linux.dev> (raw)
In-Reply-To: <BN7PR02MB414819702EA59A53FE581943D4D62@BN7PR02MB4148.namprd02.prod.outlook.com>

On 10. Mar 2025, at 21:21, Michael Kelley wrote:
> 
> It appears to me that struct vmdata_gpa_direct and struct
> vmadditional_data are also unused. Did you keep them for
> some reason? Or could they also be deleted in this patch?

I kept vmdata_gpa_direct because it is referenced in multiple comments
of other structs, for example:

/* The format must be the same as struct vmdata_gpa_direct */
struct vmbus_channel_packet_page_buffer {
	...
}

I only checked the structs used in the union and didn't check
vmadditional_data or any others, but I'll submit a v2 and remove it.

Thanks,
Thorsten


  reply	other threads:[~2025-03-10 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 19:26 Thorsten Blum
2025-03-10 20:21 ` Michael Kelley
2025-03-10 20:40   ` Thorsten Blum [this message]
2025-03-10 20:52     ` Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ACB6A959-C2CD-44E7-A1D6-AB9263C29D4D@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®