From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010AbdK1QOr (ORCPT ); Tue, 28 Nov 2017 11:14:47 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.217]:20923 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753401AbdK1QOo (ORCPT ); Tue, 28 Nov 2017 11:14:44 -0500 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw87WivNN1EDmY X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string From: "H. Nikolaus Schaller" In-Reply-To: <20171128160437.GD28152@atomide.com> Date: Tue, 28 Nov 2017 17:14:06 +0100 Cc: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Message-Id: References: <20171128160437.GD28152@atomide.com> To: Tony Lindgren X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vASGEodi013396 Hi Tony, > Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > > * H. Nikolaus Schaller [171128 15:52]: >> We can remove the unnecessary "omapdss," prefix because >> the omapdrm driver takes care of it when matching with >> the driver table. > > So is this needed as a fix or is this another clean-up? > > So is this is really needed as a fix? Hm. How do you differentiate between "fix" and "cleanup"? Maybe it is more a wording than a content issue... For me it is a "fix" because it is semantically wrong to have a prefix where it is not needed. And "fixing" it changes the compiler output by 8 bytes. "Cleanup" would be for me removing whitespace or empty lines or typos in comments. > > If this is just clean-up, again, please resend once the driver > changes have cleared. There is no change to the pandora driver involved here. The Pandora panel driver is already correct. Just the DTS has some redundant content which should be removed. So there is no dependency for this patch. BR, Nikolaus > > Regards, > > Tony > >> Signed-off-by: H. Nikolaus Schaller >> --- >> arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi >> index 53e007abdc71..64d967ec8c58 100644 >> --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi >> +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi >> @@ -626,7 +626,7 @@ >> >> lcd: lcd@1 { >> reg = <1>; /* CS1 */ >> - compatible = "omapdss,tpo,td043mtea1"; >> + compatible = "tpo,td043mtea1"; >> spi-max-frequency = <100000>; >> spi-cpol; >> spi-cpha; >> -- >> 2.12.2 >>